-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[Cygwin] CYGWIN is not WIN32 in current CMake #143130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On old CMake, Cygwin were also WIN32 but currently not. LLVM_ON_UNIX=1 and LLVM_HAVE_LINK_VERSION_SCRIPT=0 should be defined for Cygwin target.
jeremyd2019
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/198/builds/5264 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/30776 Here is the relevant piece of the build log for the reference |
On old CMake, Cygwin were also WIN32 but currently not. LLVM_ON_UNIX=1 and LLVM_HAVE_LINK_VERSION_SCRIPT=0 should be defined for Cygwin target.
On old CMake, Cygwin were also WIN32 but currently not. LLVM_ON_UNIX=1 and LLVM_HAVE_LINK_VERSION_SCRIPT=0 should be defined for Cygwin target.
On old CMake, Cygwin were also WIN32 but currently not. LLVM_ON_UNIX=1 and LLVM_HAVE_LINK_VERSION_SCRIPT=0 should be defined for Cygwin target.
On old CMake, Cygwin were also WIN32 but currently not. LLVM_ON_UNIX=1 and LLVM_HAVE_LINK_VERSION_SCRIPT=0 should be defined for Cygwin target.