[SPIRV] Add intrinsic to represent spec constants #143179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPIR-V has the concept of a specialization constant. See the [SPIR-V spec](https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#_specialization_2) for details. This commit adds the ability for the SPIR-V backend to generate the base specialization constants (OpSpecConstant, OpSpecConstantFalse, and OpSpecConstantTrue). This will be used by HLSL.
Contributor
Author
|
It look like a builtin already exists for this. I should use the one that already exists. I did not see it earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIR-V has the concept of a specialization constant. See the SPIR-V spec
for details.
This commit adds the ability for the SPIR-V backend to generate the base
specialization constants (OpSpecConstant, OpSpecConstantFalse, and
OpSpecConstantTrue).
This will be used by HLSL.
Fixes #142991