From 206cd18d0af81a60a53a19452e3da4cdeb16e84b Mon Sep 17 00:00:00 2001 From: Tobias Stadler Date: Sat, 7 Jun 2025 01:01:56 +0100 Subject: [PATCH] [llvm-remarkutil] bitstream2yaml: Keep output file Keep the output file on successful exit. --- llvm/test/tools/llvm-remarkutil/convert.test | 7 ++++--- llvm/tools/llvm-remarkutil/RemarkConvert.cpp | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/llvm/test/tools/llvm-remarkutil/convert.test b/llvm/test/tools/llvm-remarkutil/convert.test index 83023c8ce6a89..0d7ab8e4682a5 100644 --- a/llvm/test/tools/llvm-remarkutil/convert.test +++ b/llvm/test/tools/llvm-remarkutil/convert.test @@ -1,6 +1,7 @@ -RUN: llvm-remarkutil bitstream2yaml %p/Inputs/two-remarks.bitstream -o - | FileCheck %s -strict-whitespace -RUN: llvm-remarkutil yaml2bitstream %p/Inputs/two-remarks.yaml -o %t -RUN: llvm-remarkutil bitstream2yaml %t -o - | FileCheck %s -strict-whitespace +RUN: llvm-remarkutil bitstream2yaml %p/Inputs/two-remarks.bitstream -o %t.yaml +RUN: FileCheck %s -strict-whitespace < %t.yaml +RUN: llvm-remarkutil yaml2bitstream %p/Inputs/two-remarks.yaml -o %t.bitstream +RUN: llvm-remarkutil bitstream2yaml %t.bitstream -o - | FileCheck %s -strict-whitespace ; CHECK: --- !Analysis ; CHECK-NEXT: Pass: prologepilog diff --git a/llvm/tools/llvm-remarkutil/RemarkConvert.cpp b/llvm/tools/llvm-remarkutil/RemarkConvert.cpp index 35d8dcd99b4a9..207c5e0a8048b 100644 --- a/llvm/tools/llvm-remarkutil/RemarkConvert.cpp +++ b/llvm/tools/llvm-remarkutil/RemarkConvert.cpp @@ -133,6 +133,7 @@ static Error tryBitstream2YAML() { if (!E.isA()) return E; consumeError(std::move(E)); + OF->keep(); return Error::success(); } } // namespace bitstream2yaml