Skip to content

Conversation

@jurahul
Copy link
Contributor

@jurahul jurahul commented Jun 7, 2025

No description provided.

@jurahul jurahul marked this pull request as ready for review June 7, 2025 13:31
@jurahul jurahul requested a review from kazutakahirata June 7, 2025 13:31
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Jun 7, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 7, 2025

@llvm/pr-subscribers-clang

Author: Rahul Joshi (jurahul)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/143255.diff

2 Files Affected:

  • (modified) clang/include/clang/Sema/ParsedAttr.h (-3)
  • (modified) clang/include/clang/Sema/ParsedTemplate.h (+1-3)
diff --git a/clang/include/clang/Sema/ParsedAttr.h b/clang/include/clang/Sema/ParsedAttr.h
index 428d3111de80d..9e050ab9a620e 100644
--- a/clang/include/clang/Sema/ParsedAttr.h
+++ b/clang/include/clang/Sema/ParsedAttr.h
@@ -130,9 +130,6 @@ class ParsedAttr final
   size_t numTrailingObjects(OverloadToken<ParsedType>) const {
     return HasParsedType;
   }
-  size_t numTrailingObjects(OverloadToken<detail::PropertyData>) const {
-    return IsProperty;
-  }
 
 private:
   IdentifierInfo *MacroII = nullptr;
diff --git a/clang/include/clang/Sema/ParsedTemplate.h b/clang/include/clang/Sema/ParsedTemplate.h
index cff7f04666358..3a8050f9a0a3d 100644
--- a/clang/include/clang/Sema/ParsedTemplate.h
+++ b/clang/include/clang/Sema/ParsedTemplate.h
@@ -190,9 +190,7 @@ namespace clang {
     bool ArgsInvalid;
 
     /// Retrieves a pointer to the template arguments
-    ParsedTemplateArgument *getTemplateArgs() {
-      return getTrailingObjects<ParsedTemplateArgument>();
-    }
+    ParsedTemplateArgument *getTemplateArgs() { return getTrailingObjects(); }
 
     /// Creates a new TemplateIdAnnotation with NumArgs arguments and
     /// appends it to List.

@jurahul jurahul merged commit 7dbae40 into llvm:main Jun 7, 2025
12 checks passed
@jurahul jurahul deleted the clang_trailing_ParsedTemplate branch June 7, 2025 16:56
tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants