[clang][NFC] Refactor replaceExternalDecls to use llvm::any_of #143275
Conversation
snarang181
changed the title
snarang181
changed the title
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Samarth Narang (snarang181) ChangesThis patch simplifies the declaration replacement logic in replaceExternalDecls by replacing a manual loop with an idiomatic use of llvm::any_of. This improves code readability and aligns with common LLVM coding style. Full diff: https://github.com/llvm/llvm-project/pull/143275.diff 1 Files Affected:
diff --git a/clang/include/clang/AST/DeclContextInternals.h b/clang/include/clang/AST/DeclContextInternals.h
index b17b7627ac90c..a1071f62d5fae 100644
--- a/clang/include/clang/AST/DeclContextInternals.h
+++ b/clang/include/clang/AST/DeclContextInternals.h
@@ -176,14 +176,10 @@ class StoredDeclsList {
DeclListNode::Decls *Tail = erase_if([Decls](NamedDecl *ND) {
if (ND->isFromASTFile())
return true;
- // FIXME: Can we get rid of this loop completely?
- for (NamedDecl *D : Decls)
- // Only replace the local declaration if the external declaration has
- // higher visibilities.
- if (D->getModuleOwnershipKind() <= ND->getModuleOwnershipKind() &&
- D->declarationReplaces(ND, /*IsKnownNewer=*/false))
- return true;
- return false;
+ return llvm::any_of(Decls, [ND](NamedDecl *D) {
+ return D->getModuleOwnershipKind() <= ND->getModuleOwnershipKind() &&
+ D->declarationReplaces(ND, /*IsKnownNewer=*/false);
+ });
});
// Don't have any pending external decls any more.
|
|
@ChuanqiXu9, requesting your review here. |
|
IIUC the |
There was a problem hiding this comment.
I added the comment back. Is that what you meant?
snarang181
force-pushed
the
cleanup/replaceExternalDecls-loop
branch
from
dc4e3c9 to
8446545
Compare
OK. In any case, the usage of |
There was a problem hiding this comment.
Here is another missing comment.
There was a problem hiding this comment.
OK. Should we keep the FIXME?
There was a problem hiding this comment.
Retain all now, I think.
snarang181
force-pushed
the
cleanup/replaceExternalDecls-loop
branch
3 times, most recently
from
9bee4e3 to
ff09e5c
Compare
snarang181
force-pushed
the
cleanup/replaceExternalDecls-loop
branch
from
ff09e5c to
f849821
Compare
…143275) This patch simplifies the declaration replacement logic in replaceExternalDecls by replacing a manual loop with an idiomatic use of llvm::any_of. This improves code readability and aligns with common LLVM coding style.
4 participants
This patch simplifies the declaration replacement logic in replaceExternalDecls by replacing a manual loop with an idiomatic use of llvm::any_of. This improves code readability and aligns with common LLVM coding style.