diff --git a/llvm/include/llvm/ADT/bit.h b/llvm/include/llvm/ADT/bit.h index b952825e574bc..d6e33c3e6133a 100644 --- a/llvm/include/llvm/ADT/bit.h +++ b/llvm/include/llvm/ADT/bit.h @@ -300,11 +300,12 @@ template [[nodiscard]] T bit_ceil(T Value) { return T(1) << llvm::bit_width(Value - 1u); } -namespace detail { -template struct PopulationCounter { - static int count(T Value) { - // Generic version, forward to 32 bits. - static_assert(SizeOfT <= 4, "Not implemented!"); +/// Count the number of set bits in a value. +/// Ex. popcount(0xF000F000) = 8 +/// Returns 0 if the word is zero. +template >> +[[nodiscard]] inline int popcount(T Value) noexcept { + if constexpr (sizeof(T) <= 4) { #if defined(__GNUC__) return (int)__builtin_popcount(Value); #else @@ -313,11 +314,7 @@ template struct PopulationCounter { v = (v & 0x33333333) + ((v >> 2) & 0x33333333); return int(((v + (v >> 4) & 0xF0F0F0F) * 0x1010101) >> 24); #endif - } -}; - -template struct PopulationCounter { - static int count(T Value) { + } else if constexpr (sizeof(T) <= 8) { #if defined(__GNUC__) return (int)__builtin_popcountll(Value); #else @@ -327,16 +324,9 @@ template struct PopulationCounter { v = (v + (v >> 4)) & 0x0F0F0F0F0F0F0F0FULL; return int((uint64_t)(v * 0x0101010101010101ULL) >> 56); #endif + } else { + static_assert(sizeof(T) == 0, "T must be 8 bytes or less"); } -}; -} // namespace detail - -/// Count the number of set bits in a value. -/// Ex. popcount(0xF000F000) = 8 -/// Returns 0 if the word is zero. -template >> -[[nodiscard]] inline int popcount(T Value) noexcept { - return detail::PopulationCounter::count(Value); } // Forward-declare rotr so that rotl can use it.