[flang][OpenMP] Consider previous DSA for static duration variables #143601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbols that have a pre-existing DSA set in the enclosing context should not be made shared based on them being static duration variables. Suggested-by: Leandro Lupori <[email protected]> Signed-off-by: Kajetan Puchalski <[email protected]>
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-semantics @llvm/pr-subscribers-flang-openmp Author: Kajetan Puchalski (mrkajetanp) ChangesSymbols that have a pre-existing DSA set in the enclosing context should not be made shared based on them being static duration variables. Suggested-by: Leandro Lupori <[email protected]> Full diff: https://github.com/llvm/llvm-project/pull/143601.diff 1 Files Affected:
diff --git a/flang/lib/Semantics/resolve-directives.cpp b/flang/lib/Semantics/resolve-directives.cpp
index 65823adcef19d..93bf510fbc3c7 100644
--- a/flang/lib/Semantics/resolve-directives.cpp
+++ b/flang/lib/Semantics/resolve-directives.cpp
@@ -2382,7 +2382,9 @@ void OmpAttributeVisitor::CreateImplicitSymbols(const Symbol *symbol) {
dsa = prevDSA;
} else if (taskGenDir) {
// TODO 5) dummy arg in orphaned taskgen construct -> firstprivate
- if (prevDSA.test(Symbol::Flag::OmpShared) || isStaticStorageDuration) {
+ if (prevDSA.test(Symbol::Flag::OmpShared) ||
+ (isStaticStorageDuration &&
+ (prevDSA & dataSharingAttributeFlags).none())) {
// 6) shared in enclosing context -> shared
dsa = {Symbol::Flag::OmpShared};
makeSymbol(dsa);
|
tblah
reviewed
Jun 11, 2025
Contributor
tblah
left a comment
tblah
left a comment
There was a problem hiding this comment.
Please could you add a lit test for this case to guard against it regressing again in the future
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…lvm#143601) Symbols that have a pre-existing DSA set in the enclosing context should not be made shared based on them being static duration variables. Suggested-by: Leandro Lupori <[email protected]> --------- Signed-off-by: Kajetan Puchalski <[email protected]>
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
…lvm#143601) Symbols that have a pre-existing DSA set in the enclosing context should not be made shared based on them being static duration variables. Suggested-by: Leandro Lupori <[email protected]> --------- Signed-off-by: Kajetan Puchalski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbols that have a pre-existing DSA set in the enclosing context should not be made shared based on them being static duration variables.
Suggested-by: Leandro Lupori [email protected]