Skip to content

[flang][OpenMP] Consider previous DSA for static duration variables #143601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

[flang][OpenMP] Consider previous DSA for static duration variables #143601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca002b7
[flang][OpenMP] Consider previous DSA for static duration variables
mrkajetanp Jun 10, 2025
8369335
Add unit test
mrkajetanp Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flang/lib/Semantics/resolve-directives.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2382,7 +2382,9 @@ void OmpAttributeVisitor::CreateImplicitSymbols(const Symbol *symbol) {
dsa = prevDSA;
} else if (taskGenDir) {
// TODO 5) dummy arg in orphaned taskgen construct -> firstprivate
if (prevDSA.test(Symbol::Flag::OmpShared) || isStaticStorageDuration) {
if (prevDSA.test(Symbol::Flag::OmpShared) ||
(isStaticStorageDuration &&
(prevDSA & dataSharingAttributeFlags).none())) {
// 6) shared in enclosing context -> shared
dsa = {Symbol::Flag::OmpShared};
makeSymbol(dsa);
Expand Down
22 changes: 22 additions & 0 deletions flang/test/Semantics/OpenMP/implicit-dsa.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,3 +244,25 @@ subroutine implicit_dsa_test_12
!REF: /implicit_dsa_test_12/tm3a
print *,tm3a
end subroutine

! Test static duration variables with DSA set in the enclosing scope do not default to shared DSA
!DEF: /implicit_dsa_test_13_mod Module
module implicit_dsa_test_13_mod
!DEF: /implicit_dsa_test_13_mod/a PUBLIC ObjectEntity INTEGER(4)
integer::a=5
contains
!DEF: /implicit_dsa_test_13_mod/implicit_dsa_test_13 PUBLIC (Subroutine) Subprogram
subroutine implicit_dsa_test_13
!DEF: /implicit_dsa_test_13_mod/implicit_dsa_test_13/i ObjectEntity INTEGER(4)
integer i
!$omp do private(a)
!DEF: /implicit_dsa_test_13_mod/implicit_dsa_test_13/OtherConstruct1/i (OmpPrivate, OmpPreDetermined) HostAssoc INTEGER(4)
do i=0,10
!$omp task
!DEF: /implicit_dsa_test_13_mod/implicit_dsa_test_13/OtherConstruct1/OtherConstruct1/a (OmpFirstPrivate, OmpImplicit) HostAssoc INTEGER(4)
!DEF: /implicit_dsa_test_13_mod/implicit_dsa_test_13/OtherConstruct1/OtherConstruct1/i (OmpFirstPrivate, OmpImplicit) HostAssoc INTEGER(4)
a=a+i
!$omp end task
end do
end subroutine implicit_dsa_test_13
end module implicit_dsa_test_13_mod