-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[NFC] Fix outdated RecurKind comments #144014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@llvm/pr-subscribers-llvm-analysis Author: Ivan R. Ivanov (ivanradanov) ChangesFull diff: https://github.com/llvm/llvm-project/pull/144014.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Analysis/IVDescriptors.h b/llvm/include/llvm/Analysis/IVDescriptors.h
index 3b627a5140854..099b19c9cec94 100644
--- a/llvm/include/llvm/Analysis/IVDescriptors.h
+++ b/llvm/include/llvm/Analysis/IVDescriptors.h
@@ -53,13 +53,10 @@ enum class RecurKind {
FMaximumNum, ///< FP max with llvm.maximumnum semantics
FMulAdd, ///< Sum of float products with llvm.fmuladd(a * b + sum).
AnyOf, ///< AnyOf reduction with select(cmp(),x,y) where one of (x,y) is
- ///< loop invariant, and both x and y are integer type.
+ ///< loop invariant.
FindLastIV, ///< FindLast reduction with select(cmp(),x,y) where one of
- ///< (x,y) is increasing loop induction, and both x and y are
- ///< integer type.
+ ///< (x,y) is increasing loop induction.
// clang-format on
- // TODO: Any_of and FindLast reduction need not be restricted to integer type
- // only.
};
/// The RecurrenceDescriptor is used to identify recurrences variables in a
|
artagnon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mel-Chen I'm currently traveling, and away from the keyboard: could you kindly confirm that this is indeed outdated?
artagnon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct: see the 'select_const_f32_from_icmp' in select-cmp.ll and 'not_vectorized_select_float_induction_icmp' test in iv-select-cmp.ll.
|
Sorry, I was going off of these two commits which say they unify the int and float kinds, am I misunderstanding this? |
Yeah, they unify select(icmp(), x, y) and select(fcmp(), x, y). The comparison can be integer or float type, but the select operands (and the reduction op) are still restricted to be integer type, unfortunately. |
|
I see, I am sorry for the noise... |
No description provided.