[utils] Add "aarch64-apple-macosx" triple to update_llc_test_checks.py #144023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing valid triple "aarch64-apple-macosx" for usability.
Member
|
@llvm/pr-subscribers-testing-tools Author: Tomer Shafir (tomershafir) ChangesAdd a missing valid triple "aarch64-apple-macosx" for usability. Full diff: https://github.com/llvm/llvm-project/pull/144023.diff 1 Files Affected:
diff --git a/llvm/utils/UpdateTestChecks/asm.py b/llvm/utils/UpdateTestChecks/asm.py
index da7e7ecc24bdc..3754aa2eeba85 100644
--- a/llvm/utils/UpdateTestChecks/asm.py
+++ b/llvm/utils/UpdateTestChecks/asm.py
@@ -561,6 +561,7 @@ def get_run_handler(triple):
"aarch64": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE),
"aarch64-apple-darwin": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
"aarch64-apple-ios": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
+ "aarch64-apple-macosx": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
"bpf": (scrub_asm_bpf, ASM_FUNCTION_BPF_RE),
"bpfel": (scrub_asm_bpf, ASM_FUNCTION_BPF_RE),
"bpfeb": (scrub_asm_bpf, ASM_FUNCTION_BPF_RE),
|
davemgreen
approved these changes
Jun 13, 2025
Contributor
Author
|
@davemgreen can you pls merge? still waiting for commit access |
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
llvm#144023) Add a missing valid triple "aarch64-apple-macosx" for usability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing valid triple "aarch64-apple-macosx" for usability.