Skip to content

[ValueTracking] Remove opcode whitelist from matchSimpleRecurrence. #144031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

[ValueTracking] Remove opcode whitelist from matchSimpleRecurrence. #144031

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffa3807
[ValueTracking] Handle FADD and XOR in matchSimpleRecurrence.
rj-jesus Jun 12, 2025
d41fa0c
Remove whitelist from matchSimpleRecurrence.
rj-jesus Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/lib/Analysis/ValueTracking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9072,7 +9072,7 @@ bool llvm::matchSimpleRecurrence(const PHINode *P, BinaryOperator *&BO,
switch (Opcode) {
default:
continue;
// TODO: Expand list -- xor, gep, uadd.sat etc.
// TODO: Expand list -- gep, uadd.sat etc.
case Instruction::LShr:
case Instruction::AShr:
case Instruction::Shl:
Expand All @@ -9082,7 +9082,9 @@ bool llvm::matchSimpleRecurrence(const PHINode *P, BinaryOperator *&BO,
case Instruction::URem:
case Instruction::And:
case Instruction::Or:
case Instruction::Xor:
case Instruction::Mul:
case Instruction::FAdd:
case Instruction::FMul: {
Value *LL = LU->getOperand(0);
Value *LR = LU->getOperand(1);
Expand Down
Loading