Skip to content

[Clang] Fix fix-it hint regression from #143460 #144069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2025
Merged

[Clang] Fix fix-it hint regression from #143460 #144069

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be121c5
[Clang] Fix fix-it hint regression from #143460
rkirsling Jun 13, 2025
26f4db7
Update test case.
rkirsling Jun 13, 2025
425228f
Move test to new file.
rkirsling Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clang/lib/Parse/ParseStmt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,8 +836,7 @@ StmtResult Parser::ParseCaseStatement(ParsedStmtContext StmtCtx,

Diag(ExpectedLoc, diag::err_expected_after)
<< "'case'" << tok::colon
<< FixItHint::CreateInsertion(ExpectedLoc,
tok::getTokenName(tok::colon));
<< FixItHint::CreateInsertion(ExpectedLoc, ":");

ColonLoc = ExpectedLoc;
}
Expand Down
3 changes: 3 additions & 0 deletions clang/test/Parser/switch-recovery.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,9 @@ namespace GH143216 {
int f(int x) {
switch (x) {
case FOO // expected-error {{expected ':' after 'case'}}
// CHECK: {{^}} case FOO
// CHECK: {{^}} ^
// CHECK: {{^}} :
return 0;
default:
return 1;
Expand Down
Loading