[libc] Output all headers with LIBC_CONF_OUTPUT_ALL_HEADERS #144114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-libc Author: William Huynh (saturn691) ChangesFollowing discussion from https://discourse.llvm.org/t/missing-declarations-in-header-files/86678, we decided to add a flag to output all headers. Requires #144049.
Full diff: https://github.com/llvm/llvm-project/pull/144114.diff 2 Files Affected:
diff --git a/libc/cmake/modules/LLVMLibCHeaderRules.cmake b/libc/cmake/modules/LLVMLibCHeaderRules.cmake
index 99f90244e0134..add58756dfc17 100644
--- a/libc/cmake/modules/LLVMLibCHeaderRules.cmake
+++ b/libc/cmake/modules/LLVMLibCHeaderRules.cmake
@@ -97,8 +97,13 @@ function(add_gen_header target_name)
set(out_file ${LIBC_INCLUDE_DIR}/${relative_path})
set(dep_file "${out_file}.d")
set(yaml_file ${CMAKE_SOURCE_DIR}/${ADD_GEN_HDR_YAML_FILE})
+
+ if(LIBC_CONF_OUTPUT_ALL_HEADERS)
+ set(entry_points "")
+ else()
+ set(entry_points "${TARGET_ENTRYPOINT_NAME_LIST}")
+ endif()
- set(entry_points "${TARGET_ENTRYPOINT_NAME_LIST}")
list(TRANSFORM entry_points PREPEND "--entry-point=")
add_custom_command(
diff --git a/libc/test/UnitTest/CMakeLists.txt b/libc/test/UnitTest/CMakeLists.txt
index b0a3a7431c222..c32809da577d4 100644
--- a/libc/test/UnitTest/CMakeLists.txt
+++ b/libc/test/UnitTest/CMakeLists.txt
@@ -35,7 +35,7 @@ function(add_unittest_framework_library name)
else()
_get_common_test_compile_options(compile_options "" "")
target_compile_options(${name}.unit PRIVATE ${compile_options})
-endif()
+ endif()
_get_hermetic_test_compile_options(compile_options "")
target_include_directories(${name}.hermetic PRIVATE ${LIBC_INCLUDE_DIR})
|
| set(dep_file "${out_file}.d") | ||
| set(yaml_file ${CMAKE_SOURCE_DIR}/${ADD_GEN_HDR_YAML_FILE}) | ||
|
|
||
| if(LIBC_CONF_OUTPUT_ALL_HEADERS) |
Contributor
There was a problem hiding this comment.
This flag looks good, but you should add an option in the cmake to the top level CMakeLists: https://github.com/llvm/llvm-project/blob/main/libc/CMakeLists.txt#L138
Also the CONF options are intended to come from config.json, this user-exposed cmake flag can just be LIBC_OUTPUT_ALL_HEADERS
Contributor
michaelrj-google
left a comment
michaelrj-google
left a comment
There was a problem hiding this comment.
Minor phrasing suggestion, but otherwise LGTM
Co-authored-by: Michael Jones <[email protected]>
michaelrj-google
approved these changes
Jun 13, 2025
Contributor
michaelrj-google
left a comment
michaelrj-google
left a comment
There was a problem hiding this comment.
LGTM, I'll merge this once the presubmits finish
michaelrj-google
pushed a commit
that referenced
this pull request
Jun 13, 2025
Fixes a couple of bugs found when building. The PR to enable the headers can be found here: #144114. - math.yaml: float128 guard - wchar.yaml: __restrict keyword order
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
Fixes a couple of bugs found when building. The PR to enable the headers can be found here: llvm#144114. - math.yaml: float128 guard - wchar.yaml: __restrict keyword order
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
) Following discussion from https://discourse.llvm.org/t/missing-declarations-in-header-files/86678, we decided to add a flag to output all headers. Requires llvm#144049. - Allows outputting all headers - Minor whitespace change for alignment --------- Co-authored-by: Michael Jones <[email protected]>
saturn691
added a commit
to saturn691/arm-toolchain
that referenced
this pull request
Jun 16, 2025
Follows from llvm/llvm-project#144114 LLVM-libc doesn't provide all functions, but it is reasonable to expect the signature in the header file, consistent with picolibc. This allows the user to implement it later.
saturn691
added a commit
to saturn691/arm-toolchain
that referenced
this pull request
Jun 16, 2025
Follows from llvm/llvm-project#144114 LLVM-libc doesn't provide all functions, but it is reasonable to expect the signature in the header file, consistent with picolibc. This allows the user to implement it later.
saturn691
added a commit
to arm/arm-toolchain
that referenced
this pull request
Jun 16, 2025
Follows from llvm/llvm-project#144114 LLVM-libc doesn't provide all functions, but it is reasonable to expect the signature in the header file, consistent with picolibc. This allows the user to implement it later.
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
Fixes a couple of bugs found when building. The PR to enable the headers can be found here: llvm#144114. - math.yaml: float128 guard - wchar.yaml: __restrict keyword order
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
) Following discussion from https://discourse.llvm.org/t/missing-declarations-in-header-files/86678, we decided to add a flag to output all headers. Requires llvm#144049. - Allows outputting all headers - Minor whitespace change for alignment --------- Co-authored-by: Michael Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion from https://discourse.llvm.org/t/missing-declarations-in-header-files/86678, we decided to add a flag to output all headers. Requires #144049.