Skip to content

[libc] Output all headers with LIBC_CONF_OUTPUT_ALL_HEADERS #144114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025
Merged

[libc] Output all headers with LIBC_CONF_OUTPUT_ALL_HEADERS #144114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3f4b77
[libc] Output all headers with LIBC_CONF_OUTPUT_ALL_HEADERS
saturn691 Jun 13, 2025
b4b3960
fixup! [libc] Output all headers with LIBC_CONF_OUTPUT_ALL_HEADERS
saturn691 Jun 13, 2025
f90851f
Update libc/CMakeLists.txt
saturn691 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libc/cmake/modules/LLVMLibCHeaderRules.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,13 @@ function(add_gen_header target_name)
set(out_file ${LIBC_INCLUDE_DIR}/${relative_path})
set(dep_file "${out_file}.d")
set(yaml_file ${CMAKE_SOURCE_DIR}/${ADD_GEN_HDR_YAML_FILE})

if(LIBC_CONF_OUTPUT_ALL_HEADERS)
Copy link
Contributor

@michaelrj-google michaelrj-google Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag looks good, but you should add an option in the cmake to the top level CMakeLists: https://github.com/llvm/llvm-project/blob/main/libc/CMakeLists.txt#L138

Also the CONF options are intended to come from config.json, this user-exposed cmake flag can just be LIBC_OUTPUT_ALL_HEADERS

set(entry_points "")
else()
set(entry_points "${TARGET_ENTRYPOINT_NAME_LIST}")
endif()

set(entry_points "${TARGET_ENTRYPOINT_NAME_LIST}")
list(TRANSFORM entry_points PREPEND "--entry-point=")

add_custom_command(
Expand Down
2 changes: 1 addition & 1 deletion libc/test/UnitTest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function(add_unittest_framework_library name)
else()
_get_common_test_compile_options(compile_options "" "")
target_compile_options(${name}.unit PRIVATE ${compile_options})
endif()
endif()

_get_hermetic_test_compile_options(compile_options "")
target_include_directories(${name}.hermetic PRIVATE ${LIBC_INCLUDE_DIR})
Expand Down
Loading