Skip to content

Conversation

@kikairoya
Copy link
Contributor

Flang Merge CI rejects changes to llvm/Support/Compiler.h because precompiled headers aren't rebuilt when their dependencies change.

This reverts commit 60d0004.

Flang Merge CI rejects changes to llvm/Support/Compiler.h because precompiled
headers aren't rebuilt when their dependencies change.

This reverts commit 60d0004.
@llvmbot
Copy link
Member

llvmbot commented Jun 14, 2025

@llvm/pr-subscribers-llvm-support

Author: Tomohiro Kashiwada (kikairoya)

Changes

Flang Merge CI rejects changes to llvm/Support/Compiler.h because precompiled headers aren't rebuilt when their dependencies change.

This reverts commit 60d0004.


Full diff: https://github.com/llvm/llvm-project/pull/144210.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Support/Compiler.h (+1-1)
diff --git a/llvm/include/llvm/Support/Compiler.h b/llvm/include/llvm/Support/Compiler.h
index 0de789ec68c49..f6bc05011e3c3 100644
--- a/llvm/include/llvm/Support/Compiler.h
+++ b/llvm/include/llvm/Support/Compiler.h
@@ -209,7 +209,7 @@
 #define LLVM_ABI_FRIEND LLVM_ABI
 #define LLVM_ABI_EXPORT __declspec(dllexport)
 #elif defined(__ELF__) || defined(__MINGW32__) || defined(_AIX) ||             \
-    defined(__MVS__) || defined(__CYGWIN__)
+    defined(__MVS__)
 #define LLVM_ABI LLVM_ATTRIBUTE_VISIBILITY_DEFAULT
 #define LLVM_ABI_FRIEND
 #define LLVM_TEMPLATE_ABI LLVM_ATTRIBUTE_VISIBILITY_DEFAULT

@kikairoya
Copy link
Contributor Author

#144211

@jeremyd2019
Copy link
Contributor

This seems like a bug in the CI then, why revert this?

@kikairoya
Copy link
Contributor Author

I thought this should be applied after the CI script is fixed. If that's not necessary, I'll close this.

@jeremyd2019
Copy link
Contributor

I don't know - we'll see if somebody who does chimes in, but I wanted to clarify that this is really a CI bug.

@kikairoya
Copy link
Contributor Author

I'll leave this open for now, but I hope it can be resolved by fixing the CI.

@kikairoya
Copy link
Contributor Author

https://lab.llvm.org/buildbot/#/builders/207/builds/2664
CI has recovered to green (seems manually).

@kikairoya kikairoya closed this Jun 17, 2025
@kikairoya kikairoya deleted the revert-due-to-flang-ci branch June 17, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants