[mlir][vector] Add documentation note on adding new ops #144308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a note requesting that additions of new ops to the Vector dialect go through an RFC process. The goal is to clarify expectations for contributors. Note: this documents an existing (though previously unwritten) convention. See, e.g.: * https://discourse.llvm.org/t/rfc-adding-vector-to-elements-op-to-the-vector-dialect * https://discourse.llvm.org/t/rfc-improving-gather-codegen-for-vector-dialect
Member
|
@llvm/pr-subscribers-mlir Author: Andrzej Warzyński (banach-space) ChangesThis adds a note requesting that additions of new ops to the Vector Note: this documents an existing (though previously unwritten) convention. See, e.g.:
Full diff: https://github.com/llvm/llvm-project/pull/144308.diff 1 Files Affected:
diff --git a/mlir/docs/Dialects/Vector.md b/mlir/docs/Dialects/Vector.md
index ade0068c56fb6..ebeb0a2de0ff1 100644
--- a/mlir/docs/Dialects/Vector.md
+++ b/mlir/docs/Dialects/Vector.md
@@ -1,5 +1,8 @@
# 'vector' Dialect
+**Please post an RFC on the [forum](https://llvm.discourse.group/c/mlir/31)
+before adding any operation in this dialect.**
+
[TOC]
MLIR supports multi-dimensional `vector` types and custom operations on those
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a note requesting that additions of new ops to the Vector
dialect go through an RFC process. The goal is to clarify expectations
for contributors.
Note: this documents an existing (though previously unwritten) convention. See, e.g.: