[CMake] Add BINARY_DIR argument for add_lit_testsuites #144431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're doing some slightly odd things with LIT in the offload-test-suite. Specifically we generate multiple binary directories to configure and run tests with different configurations from the same source root. In this configuration the subdirectory targets need to instead point to the correct generated binary directory and use test filtering to get a subset of tests.
bogner
approved these changes
Jun 17, 2025
bob80905
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're doing some slightly odd things with LIT in the offload-test-suite. Specifically we generate multiple binary directories to configure and run tests with different configurations from the same source root.
In this configuration the subdirectory targets need to instead point to the correct generated binary directory and use test filtering to get a subset of tests.