From 6287c1fc40a7a279a791fc4f6d949c06611ce380 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 18 Jun 2025 15:38:27 -0700 Subject: [PATCH] =?UTF-8?q?Revert=20"[lldb][target]=20Add=20progress=20rep?= =?UTF-8?q?ort=20for=20wait-attaching=20to=20process=20(#14=E2=80=A6"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 03bdc0a1f68adcddef80a4e7931dbfae914e5652. --- lldb/source/Target/Target.cpp | 1 - .../TestProgressReporting.py | 31 ------------------- 2 files changed, 32 deletions(-) diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp index 8f8d2ef21cc5f..45a9e1196a049 100644 --- a/lldb/source/Target/Target.cpp +++ b/lldb/source/Target/Target.cpp @@ -3546,7 +3546,6 @@ llvm::Expected Target::GetTraceOrCreate() { } Status Target::Attach(ProcessAttachInfo &attach_info, Stream *stream) { - Progress attach_progress("Waiting to attach to process"); m_stats.SetLaunchOrAttachTime(); auto state = eStateInvalid; auto process_sp = GetProcessSP(); diff --git a/lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py b/lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py index 8198c50a5ff0d..9af53845ca1b7 100644 --- a/lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py +++ b/lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py @@ -2,7 +2,6 @@ Test that we are able to broadcast and receive progress events from lldb """ import lldb -import threading import lldbsuite.test.lldbutil as lldbutil @@ -17,36 +16,6 @@ def setUp(self): self.broadcaster, lldb.SBDebugger.eBroadcastBitProgress ) - def test_wait_attach_progress_reporting(self): - """Test that progress reports for wait attaching work as intended.""" - self.build() - target = self.dbg.CreateTarget(None) - - # Wait attach to a process, then check to see that a progress report was created - # and that its message is correct for waiting to attach to a process. - class AttachThread(threading.Thread): - def __init__(self, target): - threading.Thread.__init__(self) - self.target = target - - def run(self): - self.target.AttachToProcessWithName( - lldb.SBListener(), "a.out", True, lldb.SBError() - ) - - thread = AttachThread(target) - thread.start() - - event = lldbutil.fetch_next_event(self, self.listener, self.broadcaster) - progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event) - message = progress_data.GetValueForKey("message").GetStringValue(100) - self.assertEqual(message, "Waiting to attach to process") - - # Interrupt the process attach to keep the test from stalling. - target.process.SendAsyncInterrupt() - - thread.join() - def test_dwarf_symbol_loading_progress_report(self): """Test that we are able to fetch dwarf symbol loading progress events""" self.build()