Skip to content

[Target][KernelInfo] Fix kernel-info remarks missing from YAML optimization records #145603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[Target][KernelInfo] Fix kernel-info remarks missing from YAML optimization records #145603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1b0977
[analysis] fix unknown source locations in KernelInfo
miguelcsx Jun 24, 2025
9f77d27
[Target][KernelInfo] Move kernel-info pass to OptimizerLastEPCallback…
miguelcsx Jun 25, 2025
7d95b65
Merge branch 'llvm:main' into refac/kernel-info
miguelcsx Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,13 +942,20 @@ void AMDGPUTargetMachine::registerPassBuilderCallbacks(PassBuilder &PB) {
*this, Opt, ThinOrFullLTOPhase::FullLTOPostLink));
}
}
if (!NoKernelInfoEndLTO) {
FunctionPassManager FPM;
FPM.addPass(KernelInfoPrinter(this));
PM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
}
});

// Add kernel-info pass using OptimizerLastEPCallback to run during LTO
// while remark streamer is still active
if (!NoKernelInfoEndLTO) {
PB.registerOptimizerLastEPCallback([this](ModulePassManager &PM,
OptimizationLevel Level,
ThinOrFullLTOPhase Phase) {
FunctionPassManager FPM;
FPM.addPass(KernelInfoPrinter(this));
PM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
});
}

PB.registerRegClassFilterParsingCallback(
[](StringRef FilterName) -> RegAllocFilterFunc {
if (FilterName == "sgpr")
Expand Down
13 changes: 7 additions & 6 deletions llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,13 @@ void NVPTXTargetMachine::registerPassBuilderCallbacks(PassBuilder &PB) {
});

if (!NoKernelInfoEndLTO) {
PB.registerFullLinkTimeOptimizationLastEPCallback(
[this](ModulePassManager &PM, OptimizationLevel Level) {
FunctionPassManager FPM;
FPM.addPass(KernelInfoPrinter(this));
PM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
});
PB.registerOptimizerLastEPCallback([this](ModulePassManager &PM,
OptimizationLevel Level,
ThinOrFullLTOPhase Phase) {
FunctionPassManager FPM;
FPM.addPass(KernelInfoPrinter(this));
PM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
});
}
}

Expand Down
Loading