[lldb] include LLVMTargetParser in LINK_COMPONENTS
#145606
Conversation
|
@llvm/pr-subscribers-lldb Author: Andrew Rogers (andrurogerz) ChangesPurposeFix duplicate symbol definition errors when building LLDB BackgroundWhen building LLDB OverviewThe issue is resolved by adding Full diff: https://github.com/llvm/llvm-project/pull/145606.diff 1 Files Affected:
diff --git a/lldb/unittests/Host/CMakeLists.txt b/lldb/unittests/Host/CMakeLists.txt
index 3b20f1d723d18..5591edda38aca 100644
--- a/lldb/unittests/Host/CMakeLists.txt
+++ b/lldb/unittests/Host/CMakeLists.txt
@@ -37,7 +37,9 @@ add_lldb_unittest(HostTests
lldbUtilityHelpers
lldbHostHelpers
LLVMTestingSupport
- LLVMTargetParser
+
+ LINK_COMPONENTS
+ TargetParser
)
add_subdirectory(common)
|
|
Confirmed that this builds fine with the changes 👍 |
|
@andrurogerz do you need us to merge this for you? |
@charles-zablit yes, I would appreciate it! Thank you! |
## Purpose Fix duplicate symbol definition errors when building LLDB `HostTests` against a LLVM Windows DLL. ## Background When building LLDB `HostTests` against LLVM built as a Windows DLL, compilation fails due to multiple duplicate symbol definition errors. This is because symbols are both exported by the LLVM Windows DLL and the `LLVMTargetParser` library. ## Overview The issue is resolved by adding `LLVMTargetParser` (e.g. `TargetParser`) to `LINK_COMPONENTS`, which adds it to `LLVM_LINK_COMPONENTS`, rather than `LINK_LIBS`, which links directly against the library. This change makes it behave correctly when linking against a static or dynamic LLVM.
5 participants
Purpose
Fix duplicate symbol definition errors when building LLDB
HostTestsagainst a LLVM Windows DLL.Background
When building LLDB
HostTestsagainst LLVM built as a Windows DLL, compilation fails due to multiple duplicate symbol definition errors. This is because symbols are both exported by the LLVM Windows DLL and theLLVMTargetParserlibrary.Overview
The issue is resolved by adding
LLVMTargetParser(e.g.TargetParser) toLINK_COMPONENTS, which adds it toLLVM_LINK_COMPONENTS, rather thanLINK_LIBS, which links directly against the library. This change makes it behave correctly when linking against a static or dynamic LLVM.