Skip to content

Conversation

@amykhuang
Copy link
Collaborator

Putting libc in "LLVM_ENABLE_PROJECTS" instead of "LLVM_ENABLE_RUNTIMES" is deprecated.
The script has some logic already for doing this correctly but libc was still appearing in LLVM_ENABLE_PROJECTS.

@github-actions
Copy link

github-actions bot commented Jun 25, 2025

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r HEAD~1...HEAD .ci/compute_projects.py .ci/compute_projects_test.py
View the diff from darker here.
--- compute_projects.py	2025-06-25 22:10:42.000000 +0000
+++ compute_projects.py	2025-06-25 22:13:45.823400 +0000
@@ -51,20 +51,20 @@
     # TODO(issues/132795): LLDB should be enabled on clang changes.
     "clang": {"clang-tools-extra", "cross-project-tests"},
     "mlir": {"flang"},
     # Test everything if ci scripts are changed.
     ".ci": {
-#        "llvm",
-#        "clang",
-#        "lld",
-#        "lldb",
-#        "bolt",
-#        "clang-tools-extra",
-#        "mlir",
-#        "polly",
-#        "flang",
-#        "libclc",
+        #        "llvm",
+        #        "clang",
+        #        "lld",
+        #        "lldb",
+        #        "bolt",
+        #        "clang-tools-extra",
+        #        "mlir",
+        #        "polly",
+        #        "flang",
+        #        "libclc",
         "openmp",
     },
 }
 
 # This mapping describes runtimes that should be enabled for a specific project,
@@ -168,11 +168,11 @@
 
 
 def _compute_projects_to_test(modified_projects: Set[str], platform: str) -> Set[str]:
     projects_to_test = set()
     for modified_project in modified_projects:
-        sys.stderr.write("HELLO " +  modified_project)
+        sys.stderr.write("HELLO " + modified_project)
         if modified_project in RUNTIMES:
             continue
         # Skip all projects where we cannot run tests.
         if modified_project in PROJECT_CHECK_TARGETS:
             projects_to_test.add(modified_project)
@@ -206,12 +206,12 @@
 def _compute_runtimes_to_test(modified_projects: Set[str], platform: str) -> Set[str]:
     runtimes_to_test = set()
     for modified_project in modified_projects:
         if modified_project in DEPENDENT_RUNTIMES_TO_TEST:
             runtimes_to_test.update(DEPENDENT_RUNTIMES_TO_TEST[modified_project])
-#        if modified_project in RUNTIMES:
-#            runtimes_to_test.add(modified_project)
+    #        if modified_project in RUNTIMES:
+    #            runtimes_to_test.add(modified_project)
     return _exclude_projects(runtimes_to_test, platform)
 
 
 def _compute_runtimes_to_test_needs_reconfig(
     modified_projects: Set[str], platform: str

@amykhuang amykhuang force-pushed the enable-runtimes branch 4 times, most recently from d292caf to 68684a2 Compare June 25, 2025 21:27
@llvmbot llvmbot added the libc label Jun 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 25, 2025

@llvm/pr-subscribers-libc

Author: Amy Huang (amykhuang)

Changes

Putting libc in "LLVM_ENABLE_PROJECTS" instead of "LLVM_ENABLE_RUNTIMES" is deprecated.
The script has some logic already for doing this correctly but libc was still appearing in LLVM_ENABLE_PROJECTS.


Full diff: https://github.com/llvm/llvm-project/pull/145754.diff

2 Files Affected:

  • (modified) .ci/compute_projects.py (+13-10)
  • (modified) libc/src/math/exp10f.h (+2)
diff --git a/.ci/compute_projects.py b/.ci/compute_projects.py
index 80e4e0221b3d7..ea42432704931 100644
--- a/.ci/compute_projects.py
+++ b/.ci/compute_projects.py
@@ -53,16 +53,16 @@
     "mlir": {"flang"},
     # Test everything if ci scripts are changed.
     ".ci": {
-        "llvm",
-        "clang",
-        "lld",
-        "lldb",
-        "bolt",
-        "clang-tools-extra",
-        "mlir",
-        "polly",
-        "flang",
-        "libclc",
+#        "llvm",
+#        "clang",
+#        "lld",
+#        "lldb",
+#        "bolt",
+#        "clang-tools-extra",
+#        "mlir",
+#        "polly",
+#        "flang",
+#        "libclc",
         "openmp",
     },
 }
@@ -170,6 +170,7 @@ def _exclude_projects(current_projects: Set[str], platform: str) -> Set[str]:
 def _compute_projects_to_test(modified_projects: Set[str], platform: str) -> Set[str]:
     projects_to_test = set()
     for modified_project in modified_projects:
+        sys.stderr.write("HELLO " +  modified_project)
         if modified_project in RUNTIMES:
             continue
         # Skip all projects where we cannot run tests.
@@ -207,6 +208,8 @@ def _compute_runtimes_to_test(modified_projects: Set[str], platform: str) -> Set
     for modified_project in modified_projects:
         if modified_project in DEPENDENT_RUNTIMES_TO_TEST:
             runtimes_to_test.update(DEPENDENT_RUNTIMES_TO_TEST[modified_project])
+        if modified_project in RUNTIMES:
+            runtimes_to_test.add(modified_project)
     return _exclude_projects(runtimes_to_test, platform)
 
 
diff --git a/libc/src/math/exp10f.h b/libc/src/math/exp10f.h
index 0e537421c66a9..44789ba291823 100644
--- a/libc/src/math/exp10f.h
+++ b/libc/src/math/exp10f.h
@@ -11,6 +11,8 @@
 
 #include "src/__support/macros/config.h"
 
+// test change to trigger premerge
+
 namespace LIBC_NAMESPACE_DECL {
 
 float exp10f(float x);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants