Skip to content

Conversation

@efriedma-quic
Copy link
Collaborator

Include more specifics from recent discussion on #143034.

Include more specifics from recent discussion on llvm#143034.
@efriedma-quic efriedma-quic added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Jun 25, 2025
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jun 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 25, 2025

@llvm/pr-subscribers-clang

Author: Eli Friedman (efriedma-quic)

Changes

Include more specifics from recent discussion on #143034.


Full diff: https://github.com/llvm/llvm-project/pull/145755.diff

1 Files Affected:

  • (modified) clang/docs/ReleaseNotes.rst (+4-3)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index e1fe22393eebb..c81beb62d3f09 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -66,9 +66,10 @@ C++ Specific Potentially Breaking Changes
 - A workaround for libstdc++4.7 has been removed. Note that 4.8.3 remains the oldest
   supported libstdc++ version.
 - Added ``!nonnull/!align`` metadata to load of references for better codegen.
-- Checking for int->enum conversions in constant expressions is more strict;
-  in particular, ``const E x = (E)-1;`` is not treated as a constant if it's
-  out of range. This impacts old versions of Boost.  (#GH143034)
+- Checking for integer to enum conversions in constant expressions is more
+  strict; in particular, ``const E x = (E)-1;`` is not treated as a constant
+  if it's out of range. The Boost numeric_conversion library is impacted by
+  this; it was fixed in Boost 1.81. (#GH143034)
 
 ABI Changes in This Version
 ---------------------------

Copy link
Collaborator

@erichkeane erichkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better, and probably good enough. I find myself wondering whether we we want to say it was fixed in Boost 1.81 in commits<a/b/c> to help people know if they want to cherry-pick those. WDYT?

@efriedma-quic
Copy link
Collaborator Author

Backporting fixes to Boost seems like something most people won't want to mess with. We have a reference to the pull request if anyone wants to dig into the gory details.

@erichkeane
Copy link
Collaborator

Backporting fixes to Boost seems like something most people won't want to mess with. We have a reference to the pull request if anyone wants to dig into the gory details.

Thats fair I guess.

@efriedma-quic efriedma-quic merged commit 6bdfeca into llvm:main Jun 26, 2025
11 checks passed
anthonyhatran pushed a commit to anthonyhatran/llvm-project that referenced this pull request Jun 26, 2025
Include more specifics from recent discussion on llvm#143034.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants