[CIR][NFC] Remove duplicate code

[andykaylor]

This change removes a bit of code that was left as an artifact of a previous "not yet implemented" state. The implementation is in place, but the code to report an NYI diagnostic was left behind.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Andy Kaylor (andykaylor)

Changes

This change removes a bit of code that was left as an artifact of a previous "not yet implemented" state. The implementation is in place, but the code to report an NYI diagnostic was left behind.

---

Full diff: https://github.com/llvm/llvm-project/pull/145790.diff

1 Files Affected:

• (modified) clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp (-8)

diff --git a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
index f17eb73a9f968..05e8848884f7e 100644
--- a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
@@ -614,14 +614,6 @@ CIRGenTypes::computeRecordLayout(const RecordDecl *rd, cir::RecordType *ty) {
     }
   }
 
-  if (llvm::isa<CXXRecordDecl>(rd) && !rd->isUnion() &&
-      !rd->hasAttr<FinalAttr>()) {
-    if (lowering.astRecordLayout.getNonVirtualSize() !=
-        lowering.astRecordLayout.getSize()) {
-      cgm.errorNYI(rd->getSourceRange(), "computeRecordLayout: CXXRecordDecl");
-    }
-  }
-
   // Fill in the record *after* computing the base type.  Filling in the body
   // signifies that the type is no longer opaque and record layout is complete,
   // but we may need to recursively layout rd while laying D out as a base type.

[llvmbot]

@llvm/pr-subscribers-clangir

Author: Andy Kaylor (andykaylor)

Changes

This change removes a bit of code that was left as an artifact of a previous "not yet implemented" state. The implementation is in place, but the code to report an NYI diagnostic was left behind.

---

Full diff: https://github.com/llvm/llvm-project/pull/145790.diff

1 Files Affected:

• (modified) clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp (-8)

diff --git a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
index f17eb73a9f968..05e8848884f7e 100644
--- a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
@@ -614,14 +614,6 @@ CIRGenTypes::computeRecordLayout(const RecordDecl *rd, cir::RecordType *ty) {
     }
   }
 
-  if (llvm::isa<CXXRecordDecl>(rd) && !rd->isUnion() &&
-      !rd->hasAttr<FinalAttr>()) {
-    if (lowering.astRecordLayout.getNonVirtualSize() !=
-        lowering.astRecordLayout.getSize()) {
-      cgm.errorNYI(rd->getSourceRange(), "computeRecordLayout: CXXRecordDecl");
-    }
-  }
-
   // Fill in the record *after* computing the base type.  Filling in the body
   // signifies that the type is no longer opaque and record layout is complete,
   // but we may need to recursively layout rd while laying D out as a base type.

[andykaylor]

I'm merging this before review because another change that I'm ready to push for review depends on it.