[lldb] Add class property for the version string #145974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a class property for the version string. This allows you to use access the version string through `lldb.SBDebugger.version` instead of having to call `lldb.SBDebugger.GetVersionString()`.
Member
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesAdd a class property for the version string. This allows you to use access the version string through Full diff: https://github.com/llvm/llvm-project/pull/145974.diff 2 Files Affected:
diff --git a/lldb/bindings/interface/SBDebuggerExtensions.i b/lldb/bindings/interface/SBDebuggerExtensions.i
index ff2a0359b1363..7895fcdd72468 100644
--- a/lldb/bindings/interface/SBDebuggerExtensions.i
+++ b/lldb/bindings/interface/SBDebuggerExtensions.i
@@ -45,4 +45,17 @@ STRING_EXTENSION_OUTSIDE(SBDebugger)
lldb::FileSP GetErrorFileHandle() {
return self->GetErrorFile().GetFile();
}
+
+#ifdef SWIGPYTHON
+ %pythoncode %{
+ class staticproperty:
+ def __init__(self, func):
+ self.func = func
+ def __get__(self, instance, owner):
+ return self.func()
+ @staticproperty
+ def version():
+ return SBDebugger.GetVersionString()
+ %}
+#endif
}
diff --git a/lldb/test/API/python_api/debugger/TestDebuggerAPI.py b/lldb/test/API/python_api/debugger/TestDebuggerAPI.py
index 646ccce36530d..43f45f330ee2a 100644
--- a/lldb/test/API/python_api/debugger/TestDebuggerAPI.py
+++ b/lldb/test/API/python_api/debugger/TestDebuggerAPI.py
@@ -286,3 +286,11 @@ def remove_bar(dbg_id):
('remove bar ret', False), # remove_bar should fail, because it's already invoked and removed
('foo called', original_dbg_id), # foo should be called
])
+
+ def test_version(self):
+ instance_str = self.dbg.GetVersionString()
+ class_str = lldb.SBDebugger.GetVersionString()
+ property_str = lldb.SBDebugger.version
+
+ self.assertEqual(instance_str, class_str)
+ self.assertEqual(class_str, property_str)
|
bulbazord
approved these changes
Jun 26, 2025
|
|
||
| #ifdef SWIGPYTHON | ||
| %pythoncode %{ | ||
| class staticproperty: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a class property for the version string. This allows you to use access the version string through
lldb.SBDebugger.versioninstead of having to calllldb.SBDebugger.GetVersionString().