[lldb] Use llvm::is_contained (NFC) #146012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm::is_contained is shorter than llvm::find plus a comparison.
Member
|
@llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changesllvm::is_contained is shorter than llvm::find plus a comparison. Full diff: https://github.com/llvm/llvm-project/pull/146012.diff 1 Files Affected:
diff --git a/lldb/source/Symbol/SaveCoreOptions.cpp b/lldb/source/Symbol/SaveCoreOptions.cpp
index 0f9dbb73c1721..f93b58f59cf96 100644
--- a/lldb/source/Symbol/SaveCoreOptions.cpp
+++ b/lldb/source/Symbol/SaveCoreOptions.cpp
@@ -23,7 +23,7 @@ Status SaveCoreOptions::SetPluginName(const char *name) {
std::vector<llvm::StringRef> plugin_names =
PluginManager::GetSaveCorePluginNames();
- if (llvm::find(plugin_names, name) == plugin_names.end()) {
+ if (!llvm::is_contained(plugin_names, name)) {
StreamString stream;
stream.Printf("plugin name '%s' is not a valid ObjectFile plugin name.",
name);
|
tgymnich
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::is_contained is shorter than llvm::find plus a comparison.