[PassBuilder] Treat pipeline aliases as normal passes #146038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipelines like `-passes="default<O3>"` are currently parsed in a special way. Switch them to work like normal, parameterized module passes.
arsenm
approved these changes
Jun 27, 2025
llvm/lib/Passes/PassRegistry.def
Outdated
Comment on lines
269
to
270
| else | ||
| return buildLTOPreLinkDefaultPipeline(L); |
llvm/lib/Passes/PassRegistry.def
Outdated
| MODULE_PASS_WITH_PARAMS( | ||
| "lto-pre-link", "", [&](OptimizationLevel L) { | ||
| setupOptionsForPipelineAlias(PTO, L); | ||
| if (PTO.UnifiedLTO) |
Comment on lines
+1
to
+2
| ; RUN: not opt -passes="default" < %s 2>&1 | FileCheck %s --check-prefix=MISSING-OPT-LEVEL | ||
| ; RUN: not opt -passes="default<foo>" < %s 2>&1 | FileCheck %s --check-prefix=INVALID-OPT-LEVEL |
Contributor
There was a problem hiding this comment.
Check errors with the other names too?
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/8212 Here is the relevant piece of the build log for the reference |
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Jun 27, 2025
Pipelines like `-passes="default<O3>"` are currently parsed in a special way. Switch them to work like normal, parameterized module passes.
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipelines like
-passes="default<O3>"are currently parsed in a special way. Switch them to work like normal, parameterized module passes.