[BOLT][test] Fix NFC mismatches in perf2bolt tests #146148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero-density.s causes spurious NFC mismatches, e.g. https://lab.llvm.org/buildbot/#/builders/92/builds/21380 This is caused by NFC script wrapping llvm-bolt binary only, so that perf2bolt invocations are replaced by `llvm-bolt --agregate-only` to achieve perf2bolt behavior. Add `show-density` to the list of flags wrapping perf2bolt calls to avoid similar issues in the future. Test Plan: ``` $ bolt/utils/nfc-check-setup.py --switch-back $ bin/llvm-lit -a tools/bolt/test/X86/zero-density.s ```
aaupov
requested review from
ayermolo,
maksfb,
paschalis-mpeis,
rafaelauler and
yota9
as code owners
Member
|
@llvm/pr-subscribers-bolt Author: Amir Ayupov (aaupov) Changeszero-density.s causes spurious NFC mismatches, e.g. This is caused by NFC script wrapping llvm-bolt binary only, so that Test Plan: Full diff: https://github.com/llvm/llvm-project/pull/146148.diff 1 Files Affected:
diff --git a/bolt/utils/llvm-bolt-wrapper.py b/bolt/utils/llvm-bolt-wrapper.py
index b9d6fad825e78..b913394bce659 100755
--- a/bolt/utils/llvm-bolt-wrapper.py
+++ b/bolt/utils/llvm-bolt-wrapper.py
@@ -79,7 +79,7 @@ def get_cfg(key):
# perf2bolt mode
-PERF2BOLT_MODE = ["-aggregate-only", "-ignore-build-id"]
+PERF2BOLT_MODE = ["-aggregate-only", "-ignore-build-id", "-show-density"]
# boltdiff mode
BOLTDIFF_MODE = ["-diff-only", "-o", "/dev/null"]
|
maksfb
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zero-density.s causes spurious NFC mismatches, e.g.
https://lab.llvm.org/buildbot/#/builders/92/builds/21380
This is caused by NFC script wrapping llvm-bolt binary only, so that
perf2bolt invocations are replaced by
llvm-bolt --agregate-onlytoachieve perf2bolt behavior. Add
show-densityto the list of flagswrapping perf2bolt calls to avoid similar issues in the future.
Test Plan: