Skip to content

[lldb][mcp] Fix unix domain socket protocol server addresses #146603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

[lldb][mcp] Fix unix domain socket protocol server addresses #146603

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ffabe8
[lldb][mcp] Fix unix domain socket protocol server addresses
aperez Jul 1, 2025
42150df
Add test
aperez Jul 2, 2025
93a2730
Make sure we don't test with sockets over 104 chars
aperez Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lldb/source/Commands/CommandObjectProtocolServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,12 @@ class CommandObjectProtocolServerStart : public CommandObjectParsed {

ProtocolServer::Connection connection;
connection.protocol = protocol_and_mode->first;
connection.name =
formatv("[{0}]:{1}", uri->hostname.empty() ? "0.0.0.0" : uri->hostname,
uri->port.value_or(0));
if (connection.protocol == Socket::SocketProtocol::ProtocolUnixDomain)
connection.name = uri->path;
else
connection.name = formatv(
"[{0}]:{1}", uri->hostname.empty() ? "0.0.0.0" : uri->hostname,
uri->port.value_or(0));

if (llvm::Error error = server->Start(connection)) {
result.AppendErrorWithFormatv("{0}", llvm::fmt_consume(std::move(error)));
Expand Down
Loading