[mlir][bufferization] Do not access operation after it was replaced #146860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing an erased operation will no longer work during a One-Shot Dialect Conversion.
Member
|
@llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesAccessing an erased operation will no longer work during a One-Shot Dialect Conversion. Full diff: https://github.com/llvm/llvm-project/pull/146860.diff 1 Files Affected:
diff --git a/mlir/lib/Conversion/BufferizationToMemRef/BufferizationToMemRef.cpp b/mlir/lib/Conversion/BufferizationToMemRef/BufferizationToMemRef.cpp
index 0b5a5d8e71063..1d253632bb5a1 100644
--- a/mlir/lib/Conversion/BufferizationToMemRef/BufferizationToMemRef.cpp
+++ b/mlir/lib/Conversion/BufferizationToMemRef/BufferizationToMemRef.cpp
@@ -111,8 +111,8 @@ struct CloneOpConversion : public OpConversionPattern<bufferization::CloneOp> {
rewriter.create<memref::CastOp>(op->getLoc(), memrefType, alloc);
}
- rewriter.replaceOp(op, alloc);
rewriter.create<memref::CopyOp>(loc, op.getInput(), alloc);
+ rewriter.replaceOp(op, alloc);
return success();
}
};
|
zero9178
approved these changes
Jul 3, 2025
chelini
approved these changes
Jul 3, 2025
matthias-springer
deleted the
users/matthias-springer/bufferization_erase_later
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing an erased operation will no longer work during a One-Shot Dialect Conversion.