[mlir] Use llvm::any_of and llvm::all_of (NFC) #146947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-tosa Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/146947.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h b/mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h
index cdbebd581d9f5..9ee5079559d2b 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h
@@ -43,32 +43,22 @@ class TargetEnv {
bool allows(Profile prof) const { return enabledProfiles.count(prof) != 0; }
bool allowsAnyOf(ArrayRef<Profile> profs) const {
- const auto *chosen = llvm::find_if(
- profs, [this](tosa::Profile prof) { return allows(prof); });
- return chosen != profs.end() ? true : false;
+ return llvm::any_of(profs, [&](Profile prof) { return allows(prof); });
}
bool allowsAllOf(ArrayRef<Profile> profs) const {
- bool is_allowed = true;
- llvm::for_each(profs,
- [&](tosa::Profile prof) { is_allowed &= allows(prof); });
- return is_allowed;
+ return llvm::all_of(profs, [&](Profile prof) { return allows(prof); });
}
// Returns true if the given extension is allowed.
bool allows(Extension ext) const { return enabledExtensions.count(ext) != 0; }
bool allowsAnyOf(ArrayRef<Extension> exts) const {
- const auto *chosen = llvm::find_if(
- exts, [this](tosa::Extension ext) { return allows(ext); });
- return chosen != exts.end() ? true : false;
+ return llvm::any_of(exts, [&](Extension ext) { return allows(ext); });
}
bool allowsAllOf(ArrayRef<Extension> exts) const {
- bool is_allowed = true;
- llvm::for_each(exts,
- [&](tosa::Extension ext) { is_allowed &= allows(ext); });
- return is_allowed;
+ return llvm::all_of(exts, [&](Extension ext) { return allows(ext); });
}
private:
|
|
@llvm/pr-subscribers-mlir Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/146947.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h b/mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h
index cdbebd581d9f5..9ee5079559d2b 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h
@@ -43,32 +43,22 @@ class TargetEnv {
bool allows(Profile prof) const { return enabledProfiles.count(prof) != 0; }
bool allowsAnyOf(ArrayRef<Profile> profs) const {
- const auto *chosen = llvm::find_if(
- profs, [this](tosa::Profile prof) { return allows(prof); });
- return chosen != profs.end() ? true : false;
+ return llvm::any_of(profs, [&](Profile prof) { return allows(prof); });
}
bool allowsAllOf(ArrayRef<Profile> profs) const {
- bool is_allowed = true;
- llvm::for_each(profs,
- [&](tosa::Profile prof) { is_allowed &= allows(prof); });
- return is_allowed;
+ return llvm::all_of(profs, [&](Profile prof) { return allows(prof); });
}
// Returns true if the given extension is allowed.
bool allows(Extension ext) const { return enabledExtensions.count(ext) != 0; }
bool allowsAnyOf(ArrayRef<Extension> exts) const {
- const auto *chosen = llvm::find_if(
- exts, [this](tosa::Extension ext) { return allows(ext); });
- return chosen != exts.end() ? true : false;
+ return llvm::any_of(exts, [&](Extension ext) { return allows(ext); });
}
bool allowsAllOf(ArrayRef<Extension> exts) const {
- bool is_allowed = true;
- llvm::for_each(exts,
- [&](tosa::Extension ext) { is_allowed &= allows(ext); });
- return is_allowed;
+ return llvm::all_of(exts, [&](Extension ext) { return allows(ext); });
}
private:
|
lhutton1
approved these changes
Jul 3, 2025
kuhar
approved these changes
Jul 3, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/94/builds/8563 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.