Skip to content

Conversation

@xl4624
Copy link
Contributor

@xl4624 xl4624 commented Jul 4, 2025

Typo in

This result can either contan an `Attribute`,

to

This result can either contain an `Attribute`,

rest is clang-format

@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Jul 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 4, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Author: Xiaomin Liu (xl4624)

Changes

Typo in

This result can either contan an `Attribute`,

to

This result can either contain an `Attribute`,

rest is clang-format


Full diff: https://github.com/llvm/llvm-project/pull/146977.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Transforms/DialectConversion.h (+7-6)
diff --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h
index 81858812d2623..f6437657c9a93 100644
--- a/mlir/include/mlir/Transforms/DialectConversion.h
+++ b/mlir/include/mlir/Transforms/DialectConversion.h
@@ -221,12 +221,13 @@ class TypeConverter {
   ///
   /// The conversion functions take a non-null Type or subclass of Type and a
   /// non-null Attribute (or subclass of Attribute), and returns a
-  /// `AttributeConversionResult`. This result can either contan an `Attribute`,
-  /// which may be `nullptr`, representing the conversion's success,
-  /// `AttributeConversionResult::na()` (the default empty value), indicating
-  /// that the conversion function did not apply and that further conversion
-  /// functions should be checked, or `AttributeConversionResult::abort()`
-  /// indicating that the conversion process should be aborted.
+  /// `AttributeConversionResult`. This result can either contain an
+  /// `Attribute`, which may be `nullptr`, representing the conversion's
+  /// success, `AttributeConversionResult::na()` (the default empty value),
+  /// indicating that the conversion function did not apply and that further
+  /// conversion functions should be checked, or
+  /// `AttributeConversionResult::abort()` indicating that the conversion
+  /// process should be aborted.
   ///
   /// Registered conversion functions are callled in the reverse of the order in
   /// which they were registered.

@xl4624 xl4624 force-pushed the dialect-conversion-typo branch from 9d0b925 to a555313 Compare July 4, 2025 00:06
@xl4624 xl4624 changed the title [MLIR][NFC] Fix typo in addTypeAttributeConversion comment [MLIR][Docs] Fix typo in addTypeAttributeConversion comment Jul 4, 2025
Copy link
Member

@zero9178 zero9178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@zero9178 zero9178 merged commit 25bf90e into llvm:main Jul 4, 2025
9 checks passed
@xl4624 xl4624 deleted the dialect-conversion-typo branch July 4, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir:core MLIR Core Infrastructure mlir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants