Skip to content

[AVR] No cli for SPWRITE on XMEGA #147210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 14, 2025
Merged

[AVR] No cli for SPWRITE on XMEGA #147210

Changes from 14 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a0088b4
[AVR] No cli for SPWRITE on XMEGA
tomtor Jul 6, 2025
065e8a3
formatting
tomtor Jul 6, 2025
24afcd7
reorder
tomtor Jul 8, 2025
f80f924
no constants for SP location
tomtor Jul 8, 2025
2e7629e
Test and optimize for SPL only device
tomtor Jul 8, 2025
28b238a
Formatting for SPL only test
tomtor Jul 8, 2025
82c45cb
Another SPL only test
tomtor Jul 8, 2025
2a3a950
Fix another SPL only test
tomtor Jul 8, 2025
d84f918
Revert "Fix another SPL only test"
tomtor Jul 8, 2025
4941e5e
Revert "Another SPL only test"
tomtor Jul 8, 2025
5f96043
Revert "Formatting for SPL only test"
tomtor Jul 8, 2025
7a95adc
Revert "Test and optimize for SPL only device"
tomtor Jul 8, 2025
30cfc76
Revert "no constants for SP location"
tomtor Jul 8, 2025
42e0353
Revert "reorder"
tomtor Jul 8, 2025
72b3d4f
use RegSPL/H instead of inline constants
tomtor Jul 13, 2025
ca0bf9a
Add tests and check to prevent write -1
tomtor Jul 13, 2025
de13c77
Add tests and check to prevent write -1
tomtor Jul 13, 2025
2756016
Format Add tests and check to prevent write -1
tomtor Jul 13, 2025
2fa1b4e
remove empty line
tomtor Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 40 additions & 21 deletions llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2531,27 +2531,46 @@ bool AVRExpandPseudo::expand<AVR::SPWRITE>(Block &MBB, BlockIt MBBI) {
unsigned Flags = MI.getFlags();
TRI->splitReg(SrcReg, SrcLoReg, SrcHiReg);

buildMI(MBB, MBBI, AVR::INRdA)
.addReg(STI.getTmpRegister(), RegState::Define)
.addImm(STI.getIORegSREG())
.setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::BCLRs).addImm(0x07).setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::OUTARr)
.addImm(0x3e)
.addReg(SrcHiReg, getKillRegState(SrcIsKill))
.setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::OUTARr)
.addImm(STI.getIORegSREG())
.addReg(STI.getTmpRegister(), RegState::Kill)
.setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::OUTARr)
.addImm(0x3d)
.addReg(SrcLoReg, getKillRegState(SrcIsKill))
.setMIFlags(Flags);
// From the XMEGA series manual:
// To prevent corruption when updating the stack pointer from software,
// a write to SPL will automatically disable interrupts
// for up to four instructions or until the next I/O memory write.
if (STI.getELFArch() >= 102) { // An XMEGA device

buildMI(MBB, MBBI, AVR::OUTARr)
.addImm(0x3d)
.addReg(SrcLoReg, getKillRegState(SrcIsKill))
.setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::OUTARr)
.addImm(0x3e)
.addReg(SrcHiReg, getKillRegState(SrcIsKill))
.setMIFlags(Flags);

} else { // Disable interrupts for older devices (3 extra instructions)

buildMI(MBB, MBBI, AVR::INRdA)
.addReg(STI.getTmpRegister(), RegState::Define)
.addImm(STI.getIORegSREG())
.setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::BCLRs).addImm(0x07).setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::OUTARr)
.addImm(0x3e)
.addReg(SrcHiReg, getKillRegState(SrcIsKill))
.setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::OUTARr)
.addImm(STI.getIORegSREG())
.addReg(STI.getTmpRegister(), RegState::Kill)
.setMIFlags(Flags);

buildMI(MBB, MBBI, AVR::OUTARr)
.addImm(0x3d)
.addReg(SrcLoReg, getKillRegState(SrcIsKill))
.setMIFlags(Flags);
}

MI.eraseFromParent();
return true;
Expand Down