[mlir][spirv] TableGen defintion SPIRV_Composite to include SPIRV_AnyTensorArm

[mahabadm]

SPIRV_AnyTensorArm is a recently added composite type. This patch adds to the list of composite type represented by SPIRV_Composite. This was missing from a previous patch where SPIRV_AnyTensorArm was introduced.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-mlir-spirv

Author: Mohammadreza Ameri Mahabadian (mahabadm)

Changes

SPIRV_AnyTensorArm is a recently added composite type. This patch addes to the list of composite type represented by SPIRV_Composite

---

Full diff: https://github.com/llvm/llvm-project/pull/147567.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td (+1-1)

diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
index d874817e6888d..910418f1706a6 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
@@ -4248,7 +4248,7 @@ def SPIRV_Scalar : AnyTypeOf<[SPIRV_Numerical, SPIRV_Bool]>;
 def SPIRV_Aggregate : AnyTypeOf<[SPIRV_AnyArray, SPIRV_AnyRTArray, SPIRV_AnyStruct]>;
 def SPIRV_Composite :
     AnyTypeOf<[SPIRV_Vector, SPIRV_AnyArray, SPIRV_AnyRTArray, SPIRV_AnyStruct,
-               SPIRV_AnyCooperativeMatrix, SPIRV_AnyMatrix]>;
+               SPIRV_AnyCooperativeMatrix, SPIRV_AnyMatrix, SPIRV_AnyTensorArm]>;
 def SPIRV_Type : AnyTypeOf<[
     SPIRV_Void, SPIRV_Bool, SPIRV_Integer, SPIRV_AnyFloat, SPIRV_Vector,
     SPIRV_AnyPtr, SPIRV_AnyArray, SPIRV_AnyRTArray, SPIRV_AnyStruct,

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Mohammadreza Ameri Mahabadian (mahabadm)

Changes

SPIRV_AnyTensorArm is a recently added composite type. This patch addes to the list of composite type represented by SPIRV_Composite

---

Full diff: https://github.com/llvm/llvm-project/pull/147567.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td (+1-1)

diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
index d874817e6888d..910418f1706a6 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
@@ -4248,7 +4248,7 @@ def SPIRV_Scalar : AnyTypeOf<[SPIRV_Numerical, SPIRV_Bool]>;
 def SPIRV_Aggregate : AnyTypeOf<[SPIRV_AnyArray, SPIRV_AnyRTArray, SPIRV_AnyStruct]>;
 def SPIRV_Composite :
     AnyTypeOf<[SPIRV_Vector, SPIRV_AnyArray, SPIRV_AnyRTArray, SPIRV_AnyStruct,
-               SPIRV_AnyCooperativeMatrix, SPIRV_AnyMatrix]>;
+               SPIRV_AnyCooperativeMatrix, SPIRV_AnyMatrix, SPIRV_AnyTensorArm]>;
 def SPIRV_Type : AnyTypeOf<[
     SPIRV_Void, SPIRV_Bool, SPIRV_Integer, SPIRV_AnyFloat, SPIRV_Vector,
     SPIRV_AnyPtr, SPIRV_AnyArray, SPIRV_AnyRTArray, SPIRV_AnyStruct,

[kuhar]

Is there some way to test this?

[mahabadm]

Is there some way to test this?

@kuhar Thanks for your comment. This is basically just something left from a previous patch. There are currently just a few ops using SPIRV_Composite so I'm not sure if there is much value to add tests for this. But please let me know if you have a particular suggestion for tests.

[kuhar]

Is there some way to test this?

@kuhar Thanks for your comment. This is basically just something left from a previous patch. There are currently just a few ops using SPIRV_Composite so I'm not sure if there is much value to add tests for this. But please let me know if you have a particular suggestion for tests.

Can you update the PR message with this piece of context? This way we will be able to track where it came from

[mahabadm]

Is there some way to test this?

@kuhar Thanks for your comment. This is basically just something left from a previous patch. There are currently just a few ops using SPIRV_Composite so I'm not sure if there is much value to add tests for this. But please let me know if you have a particular suggestion for tests.

Can you update the PR message with this piece of context? This way we will be able to track where it came from

Thanks for your note. I have updated the description.

[mahabadm]

@kuhar Please let me know if there's anything else needed here. Otherwise, if all looks good, would it be possible to merge please? Thank you.

[github-actions]

@mahabadm Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!