[flang][acc][NFC] Add deviation to the spec that declaring the same variable is permitted #148288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-openacc Author: Susan Tan (ス-ザン タン) (SusanTan) ChangesOpenACC spec says Full diff: https://github.com/llvm/llvm-project/pull/148288.diff 1 Files Affected:
diff --git a/flang/docs/OpenACC.md b/flang/docs/OpenACC.md
index 87f30ccd953b6..cbb2a91f0963b 100644
--- a/flang/docs/OpenACC.md
+++ b/flang/docs/OpenACC.md
@@ -27,6 +27,9 @@ local:
* `!$acc cache` directive accepts scalar variable.
* The `!$acc declare` directive accepts assumed size array arguments for
`deviceptr` and `present` clauses.
+* The OpenACC specification disallows a variable appearing multiple times in
+ clauses of `!$acc declare` directives for a function, subroutine, program,
+ or module, but we allow it with a warning.
## Remarks about incompatibilities with other implementations
* Array element references in the data clauses are equivalent to array sections
|
clementval
changed the title
Contributor
|
You can add |
SusanTan
changed the title
SusanTan
changed the title
flang/docs/OpenACC.md
Outdated
| `deviceptr` and `present` clauses. | ||
| * The OpenACC specification disallows a variable appearing multiple times in | ||
| clauses of `!$acc declare` directives for a function, subroutine, program, | ||
| or module, but we allow it with a warning. |
Contributor
There was a problem hiding this comment.
can we change
"but we allow it with a warning" to "but it is allowed with a warning when same clause is used"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenACC spec says
A var may appear at most once in all the clauses of declare directives for a function, subroutine, program, or module.but our implementation allows it with a warning generated. Add this to the diviation list for record.