Fix OpenMPDialect.cpp build error #148952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-flang-openmp Author: Rahul Joshi (jurahul) ChangesFull diff: https://github.com/llvm/llvm-project/pull/148952.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
index 486935fe7341c..769aee64e1695 100644
--- a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
+++ b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
@@ -3867,7 +3867,7 @@ LogicalResult ScanOp::verify() {
/// Verifies align clause in allocate directive
LogicalResult AllocateDirOp::verify() {
- std::optional<u_int64_t> align = this->getAlign();
+ std::optional<uint64_t> align = this->getAlign();
if (align.has_value()) {
if ((align.value() > 0) && !llvm::has_single_bit(align.value()))
|
Member
|
@llvm/pr-subscribers-mlir-openmp Author: Rahul Joshi (jurahul) ChangesFull diff: https://github.com/llvm/llvm-project/pull/148952.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
index 486935fe7341c..769aee64e1695 100644
--- a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
+++ b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
@@ -3867,7 +3867,7 @@ LogicalResult ScanOp::verify() {
/// Verifies align clause in allocate directive
LogicalResult AllocateDirOp::verify() {
- std::optional<u_int64_t> align = this->getAlign();
+ std::optional<uint64_t> align = this->getAlign();
if (align.has_value()) {
if ((align.value() > 0) && !llvm::has_single_bit(align.value()))
|
klausler
reviewed
Jul 15, 2025
Contributor
klausler
left a comment
klausler
left a comment
There was a problem hiding this comment.
Ping me if/when it survives CI on Windows.
Contributor
Contributor
|
@jurahul Thank you for fixing it. |
klausler
approved these changes
Jul 15, 2025
bonsthie
pushed a commit
to bonsthie/llvm-project
that referenced
this pull request
Jul 22, 2025
steven-studio
pushed a commit
to steven-studio/llvm-project
that referenced
this pull request
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.