[lldb] Fix plugin test to not rely on enabled targets

[dmpots]

The plugins completion test was checking completions for the abi plugins. But the available abi plugins will depend on which targets are enabled in the cmake build configuration.

This PR updates the test to check for the json object file instead which should be enabled on all builds.

[dmpots]

This is to fix a buildbot failure: https://lab.llvm.org/buildbot/#/builders/195/builds/11884

[llvmbot]

@llvm/pr-subscribers-lldb

Author: David Peixotto (dmpots)

Changes

The plugins completion test was checking completions for the abi plugins. But the available abi plugins will depend on which targets are enabled in the cmake build configuration.

This PR updates the test to check for the json object file instead which should be enabled on all builds.

---

Full diff: https://github.com/llvm/llvm-project/pull/148956.diff

1 Files Affected:

• (modified) lldb/test/API/commands/plugin/TestPlugin.py (+4-4)

diff --git a/lldb/test/API/commands/plugin/TestPlugin.py b/lldb/test/API/commands/plugin/TestPlugin.py
index e7de7a3f797f1..bd8ab9604538e 100644
--- a/lldb/test/API/commands/plugin/TestPlugin.py
+++ b/lldb/test/API/commands/plugin/TestPlugin.py
@@ -82,10 +82,10 @@ def test_completions(self):
         )
 
         # A completion for a full namespace should contain the plugins in that namespace.
-        self.completions_contain("plugin list abi", ["abi.sysv-x86_64"])
-        self.completions_contain("plugin list abi.", ["abi.sysv-x86_64"])
-        self.completions_contain("plugin list abi.s", ["abi.sysv-x86_64"])
-        self.completions_contain("plugin list abi.sysv-x", ["abi.sysv-x86_64"])
+        self.completions_contain("plugin list object-file", ["object-file.JSON"])
+        self.completions_contain("plugin list object-file.", ["object-file.JSON"])
+        self.completions_contain("plugin list object-file.J", ["object-file.JSON"])
+        self.completions_contain("plugin list object-file.JS", ["object-file.JSON"])
 
         # Check for a completion that is a both a complete namespace and a prefix of
         # another namespace. It should return the completions for the plugins in the completed

[Jlalond]

LGTM if object file json will always be present, otherwise gating this test makes sense IMO.

[Jlalond]

The object file Json plugin will always be there?

Can we gate the test in such a way to ensure that?

[dmpots]

I do not see anything in the CMakeLists.txt file that conditionally enables the JSON object file plugin (unlike the ABI plugins). I also do not see any gates in the json object file tests:

llvm-project/lldb/test/API/functionalities/json/object-file/TestObjectFileJSON.py

Line 13 in bc187b8

class TestObjectFileJSON(TestBase):

So I think it should always be there.