Skip to content

[lldb] Fix plugin test to not rely on enabled targets #148956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

[lldb] Fix plugin test to not rely on enabled targets #148956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lldb/test/API/commands/plugin/TestPlugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ def test_completions(self):
)

# A completion for a full namespace should contain the plugins in that namespace.
self.completions_contain("plugin list abi", ["abi.sysv-x86_64"])
self.completions_contain("plugin list abi.", ["abi.sysv-x86_64"])
self.completions_contain("plugin list abi.s", ["abi.sysv-x86_64"])
self.completions_contain("plugin list abi.sysv-x", ["abi.sysv-x86_64"])
self.completions_contain("plugin list object-file", ["object-file.JSON"])
Copy link
Contributor

@Jlalond Jlalond Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object file Json plugin will always be there?

Can we gate the test in such a way to ensure that?

Copy link
Contributor Author

@dmpots dmpots Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see anything in the CMakeLists.txt file that conditionally enables the JSON object file plugin (unlike the ABI plugins). I also do not see any gates in the json object file tests:

llvm-project/lldb/test/API/functionalities/json/object-file/TestObjectFileJSON.py

Line 13 in bc187b8

class TestObjectFileJSON(TestBase):

So I think it should always be there.

self.completions_contain("plugin list object-file.", ["object-file.JSON"])
self.completions_contain("plugin list object-file.J", ["object-file.JSON"])
self.completions_contain("plugin list object-file.JS", ["object-file.JSON"])

# Check for a completion that is a both a complete namespace and a prefix of
# another namespace. It should return the completions for the plugins in the completed
Expand Down
Loading