[lldb][rpc] Disable building lldb-rpc-gen tool #150699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) ChangesDisabling the lldb-rpc-gen tool while issues with certain builds are solved: #148996 Full diff: https://github.com/llvm/llvm-project/pull/150699.diff 1 Files Affected:
diff --git a/lldb/cmake/modules/LLDBConfig.cmake b/lldb/cmake/modules/LLDBConfig.cmake
index 1bc494a48cb03..606639a3c5373 100644
--- a/lldb/cmake/modules/LLDBConfig.cmake
+++ b/lldb/cmake/modules/LLDBConfig.cmake
@@ -329,7 +329,7 @@ endif()
if (NOT DEFINED LLDB_CAN_USE_LLDB_RPC_SERVER)
if ((CMAKE_CROSSCOMPILING OR LLVM_HOST_TRIPLE MATCHES "${LLVM_DEFAULT_TARGET_TRIPLE}") AND
CMAKE_SYSTEM_NAME MATCHES "AIX|Android|Darwin|FreeBSD|Linux|NetBSD|OpenBSD|Windows")
- set(LLDB_CAN_USE_LLDB_RPC_SERVER ON)
+ set(LLDB_CAN_USE_LLDB_RPC_SERVER OFF)
else()
set(LLDB_CAN_USE_LLDB_RPC_SERVER OFF)
endif()
@@ -339,7 +339,7 @@ if (CMAKE_CROSSCOMPILING)
set(LLDB_BUILD_LLDBRPC OFF CACHE BOOL "")
get_host_tool_path(lldb-rpc-gen LLDB_RPC_GEN_EXE lldb_rpc_gen_exe lldb_rpc_gen_target)
else()
- set(LLDB_BUILD_LLDBRPC ON CACHE BOOL "")
+ set(LLDB_BUILD_LLDBRPC OFF CACHE BOOL "")
endif()
include(LLDBGenerateConfig)
|
|
@chelcassanova , you just completely disable RPC with there changes and there is no way to turn it ON. I would like to propose using either (with additional checks inside of these conditions if necessary). The second variant could be optimal as a quick fix. |
chelcassanova
force-pushed
the
disable-rpc-gen-tool
branch
from
cd91a8c to
9890570
Compare
mstorsjo
approved these changes
Jul 25, 2025
chelcassanova
force-pushed
the
disable-rpc-gen-tool
branch
from
9890570 to
e2aeab7
Compare
vvereschaka
reviewed
Jul 25, 2025
Disabling the lldb-rpc-gen tool while issues with certain builds are solved: llvm#148996
chelcassanova
force-pushed
the
disable-rpc-gen-tool
branch
from
e2aeab7 to
5b3bf87
Compare
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
Disabling the lldb-rpc-gen tool while issues with certain builds are solved: llvm#148996
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 11, 2025
Disabling the lldb-rpc-gen tool while issues with certain builds are solved: llvm#148996 (cherry picked from commit 67b5195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling the lldb-rpc-gen tool while issues with certain builds are solved: #148996