[libc][bazel] Allow building llvm_libc_types_float128 on Windows. #150704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This target was marked as Linux-only in 51a4ab2 to make "blaze build @llvm-project//libc/..." clean (which it still is). There's nothing Linux-specific about this header libary, we just use "target_incompatible_with" clause here to ensure that all libc functions for float128 types won't be built on Mac, in lieu of a better exclusion mechanism in Bazel. However, since llvm_libc_types_float128 is now a transitive dependency of ":libcxx_shared_headers" used for hand-in-hand code sharing with libc++, we may need to build this target even on platforms that don't have float128. Fow now, mark this target Windows-compatible to unlock the downstream Windows Bazel build of ":libcxx_shared_headers".
Member
|
@llvm/pr-subscribers-libc Author: Alexey Samsonov (vonosmas) ChangesThis target was marked as Linux-only in 51a4ab2 to make "bazel build @llvm-project//libc/..." clean (which it still is). There's nothing Linux-specific about this header libary, we just use "target_incompatible_with" clause here to ensure that all libc functions for float128 types won't be built on Mac, in lieu of a better exclusion mechanism in Bazel. However, since llvm_libc_types_float128 is now a transitive dependency of ":libcxx_shared_headers" used for hand-in-hand code sharing with libc++, we may need to build this target even on platforms that don't have float128. Fow now, mark this target Windows-compatible to unlock the downstream Windows Bazel build of ":libcxx_shared_headers". Full diff: https://github.com/llvm/llvm-project/pull/150704.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 5ae999b8a9dcf..a6b71b0e82f45 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -159,6 +159,7 @@ libc_support_library(
hdrs = ["include/llvm-libc-types/float128.h"],
target_compatible_with = select({
"@platforms//os:linux": [],
+ "@platforms//os:windows": [],
"//conditions:default": ["@platforms//:incompatible"],
}),
deps = [":llvm_libc_macros_float_macros"],
|
lntue
approved these changes
Jul 25, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
…vm#150704) This target was marked as Linux-only in 51a4ab2 to make "bazel build @llvm-project//libc/..." clean (which it still is). There's nothing Linux-specific about this header library, we just use "target_incompatible_with" clause here to ensure that all libc functions for float128 types won't be built on Mac, in lieu of a better exclusion mechanism in Bazel. However, since llvm_libc_types_float128 is now a transitive dependency of ":libcxx_shared_headers" used for hand-in-hand code sharing with libc++, we may need to build this target even on platforms that don't have float128. Fow now, mark this target Windows-compatible to unlock the downstream Windows Bazel build of ":libcxx_shared_headers".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This target was marked as Linux-only in 51a4ab2 to make "bazel build @llvm-project//libc/..." clean (which it still is).
There's nothing Linux-specific about this header libary, we just use "target_incompatible_with" clause here to ensure that all libc functions for float128 types won't be built on Mac, in lieu of a better exclusion mechanism in Bazel.
However, since llvm_libc_types_float128 is now a transitive dependency of ":libcxx_shared_headers" used for hand-in-hand code sharing with libc++, we may need to build this target even on platforms that don't have float128.
Fow now, mark this target Windows-compatible to unlock the downstream Windows Bazel build of ":libcxx_shared_headers".