[mlir] Add VCIX dialect maintainer #151369
Conversation
mshockwave
requested review from
banach-space,
ftynse,
gysit and
matthias-springer
|
@llvm/pr-subscribers-mlir Author: Min-Yih Hsu (mshockwave) ChangesAs per https://discourse.llvm.org/t/mlir-project-maintainers/87189 This patch adds myself as the maintainer for the VCIX dialect in the egress dialect category. @llvm/mlir-area-team Full diff: https://github.com/llvm/llvm-project/pull/151369.diff 1 Files Affected:
diff --git a/mlir/Maintainers.md b/mlir/Maintainers.md
index 7c852ef4e1771..abebec9bbab44 100644
--- a/mlir/Maintainers.md
+++ b/mlir/Maintainers.md
@@ -44,6 +44,12 @@ MLIR components pertaining to egress flows from MLIR, in particular to LLVM IR.
[@gysit](https://github.com/gysit) (GitHub),
gysit (Discourse)
+### Dialects
+
+#### CPU Dialects
+
+* 'vcix' Dialect ([@mshockwave](https://github.com/mshockwave))
+
## Tensor Compiler
MLIR components specific to construction of compilers for tensor algebra, in
|
banach-space
left a comment
banach-space
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment re formatting the Maintainers file. That's probably for @llvm/mlir-area-team to guide us.
| ### Dialects | ||
|
|
||
| #### CPU Dialects | ||
|
|
||
| * 'vcix' Dialect ([@mshockwave](https://github.com/mshockwave)) | ||
|
|
There was a problem hiding this comment.
Not sure how to layer this - should this be a sub-section of Egress?
There was a problem hiding this comment.
I follow the format of the original Discourses post as well as #150945. I'm open to other formatting.
There was a problem hiding this comment.
I'd rather do this in one go than having each one adding their own, at least in this initial period. Later, we can do that one by one.
|
Can we have the whole thing in one go? @banach-space, do you mind replicating #150945 |
I saw the Discourses post and thought that it might be a good idea to send the PR before I completely forgot 😛 . Otherwise I'm totally fine with doing the whole thing (i.e. egress dialects category) in one go. |
Sure: #151721 |
|
Close in favor of #151721 |
5 participants
As per https://discourse.llvm.org/t/mlir-project-maintainers/87189
This patch adds myself as the maintainer for the VCIX dialect in the egress dialect category.
@llvm/mlir-area-team
@matthias-springer
@banach-space
@gysit