[flang][runtime] Optimize Descriptor::FixedStride() #151755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klausler
changed the title
klausler
force-pushed
the
faster-fm
branch
2 times, most recently
from
71b302f to
ed6a67e
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
klausler
force-pushed
the
faster-fm
branch
2 times, most recently
from
65480f5 to
830e939
Compare
Put the common cases on fast paths, and don't depend on IsContiguous() in the general case path. Add a unit test, too.
eugeneepshteyn
approved these changes
Aug 4, 2025
akuhlens
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the common cases on fast paths, and don't depend on IsContiguous() in the general case path. Add a unit test, too.