Skip to content

[libc] fix build errors caused by cbrt. #151879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2025
Merged

[libc] fix build errors caused by cbrt. #151879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a24d3d
[libc] fix build errors caused by cbrt.
bassiounix Aug 3, 2025
6a312f5
add type alias
bassiounix Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libc/src/__support/math/cbrt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ LIBC_INLINE static constexpr double get_error(const DoubleDouble &x_3,

LIBC_INLINE static constexpr double cbrt(double x) {
using DoubleDouble = fputil::DoubleDouble;
using Float128 = fputil::DyadicFloat<128>;
using namespace cbrt_internal;
using FPBits = fputil::FPBits<double>;

Expand Down Expand Up @@ -295,6 +294,8 @@ LIBC_INLINE static constexpr double cbrt(double x) {
if (LIBC_LIKELY(r2_upper == r2_lower))
return update_exponent(r2_upper);

using Float128 = fputil::DyadicFloat<128>;

// TODO: Investigate removing float128 and just list exceptional cases.
// Apply another Newton iteration with ~126-bit accuracy.
Float128 x2_f128 = fputil::quick_add(Float128(x2.hi), Float128(x2.lo));
Expand Down
Loading