Skip to content

[IR] Improve code in isIdenticalToWhenDefined (NFC) #151881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

[IR] Improve code in isIdenticalToWhenDefined (NFC) #151881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions llvm/lib/IR/Instruction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,14 +942,13 @@ bool Instruction::isIdenticalToWhenDefined(const Instruction *I,

// We have two instructions of identical opcode and #operands. Check to see
// if all operands are the same.
if (!std::equal(op_begin(), op_end(), I->op_begin()))
if (!equal(operands(), I->operands()))
return false;

// WARNING: this logic must be kept in sync with EliminateDuplicatePHINodes()!
if (const PHINode *thisPHI = dyn_cast<PHINode>(this)) {
const PHINode *otherPHI = cast<PHINode>(I);
return std::equal(thisPHI->block_begin(), thisPHI->block_end(),
otherPHI->block_begin());
if (const PHINode *Phi = dyn_cast<PHINode>(this)) {
const PHINode *OtherPhi = cast<PHINode>(I);
return equal(Phi->blocks(), OtherPhi->blocks());
}

return this->hasSameSpecialState(I, /*IgnoreAlignment=*/false,
Expand Down