[mlir][OpenMP][NFC] Fix gcc 14 warning #151941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC couldn't tell that the enum is checked exhaustively and so was warning about there being no return on this path from the function.
Member
|
@llvm/pr-subscribers-mlir-openmp @llvm/pr-subscribers-flang-openmp Author: Tom Eccles (tblah) ChangesGCC couldn't tell that the enum is checked exhaustively and so was warning about there being no return on this path from the function. Full diff: https://github.com/llvm/llvm-project/pull/151941.diff 1 Files Affected:
diff --git a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
index 49e1e55c686a6..762cc88d9fc3d 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
@@ -3391,6 +3391,7 @@ static llvm::omp::Directive convertCancellationConstructType(
case omp::ClauseCancellationConstructType::Taskgroup:
return llvm::omp::Directive::OMPD_taskgroup;
}
+ llvm_unreachable("Unhandled cancellation construct type");
}
static LogicalResult
|
joker-eph
pushed a commit
to joker-eph/llvm-project
that referenced
this pull request
Aug 20, 2025
GCC couldn't tell that the enum is checked exhaustively and so was warning about there being no return on this path from the function.
tru
pushed a commit
that referenced
this pull request
Aug 26, 2025
GCC couldn't tell that the enum is checked exhaustively and so was warning about there being no return on this path from the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC couldn't tell that the enum is checked exhaustively and so was warning about there being no return on this path from the function.