[CI] Refactor monolithic-* scripts to use common utils.sh #152199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
boomanaiden154
requested review from
DavidSpickett,
Endilll,
Keenuts,
cmtice,
dschuff,
gburgessiv and
lnihlen
Collaborator
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
Agree with the changes overall but there are problems in the CI runs to deal with. Unless they are because this is part of a stack of PRs?
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Contributor
Author
Fixed. I had the directory screwed up in the |
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Aug 6, 2025
This patch refactors big chunks of the common functionality shared between monolithic-linux.sh and monolithic-windows.sh to a separate script, utils.sh, that is then sourced in both of the files. This makes it a bit easier to maintain the scripts. Platform differences should not be a large deal for the setup here as we are using bash as the shell on both Linux and Windows. Pull Request: llvm#152199
boomanaiden154
added a commit
that referenced
this pull request
Aug 6, 2025
This patch adds the python-is-python3 package to the CI container. Windows by default uses python instead of python3, which prevents code sharing without additionaly hackery. This should fix that and allow for #152199 to land.
cmtice
approved these changes
Aug 6, 2025
boomanaiden154
changed the base branch from
users/boomanaiden154/main.ci-refactor-monolithic-scripts-to-use-common-utilssh
to
main
boomanaiden154
deleted the
users/boomanaiden154/ci-refactor-monolithic-scripts-to-use-common-utilssh
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 6, 2025
This patch refactors big chunks of the common functionality shared between monolithic-linux.sh and monolithic-windows.sh to a separate script, utils.sh, that is then sourced in both of the files. This makes it a bit easier to maintain the scripts. Platform differences should not be a large deal for the setup here as we are using bash as the shell on both Linux and Windows. Reviewers: lnihlen, gburgessiv, Keenuts, DavidSpickett, dschuff, cmtice, Endilll Reviewed By: DavidSpickett, cmtice Pull Request: llvm/llvm-project#152199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors big chunks of the common functionality shared
between monolithic-linux.sh and monolithic-windows.sh to a separate
script, utils.sh, that is then sourced in both of the files. This makes
it a bit easier to maintain the scripts.
Platform differences should not be a large deal for the setup here as we
are using bash as the shell on both Linux and Windows.