Skip to content

Conversation

@CatherineMoore
Copy link
Contributor

Update printf format string to match argument list

Update printf format string to match argument list
@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels Aug 8, 2025
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@jhuber6 jhuber6 changed the title Update ompdModule.c [OpenMP] Update ompdModule.c Aug 8, 2025
@jhuber6 jhuber6 changed the title [OpenMP] Update ompdModule.c [OpenMP] Update ompdModule.c printf to match argument type Aug 8, 2025
Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I don't see what clang-format is complaining about

@llvmbot
Copy link
Member

llvmbot commented Aug 12, 2025

@llvm/pr-subscribers-backend-x86

Author: None (CatherineMoore)

Changes

Update printf format string to match argument list


Full diff: https://github.com/llvm/llvm-project/pull/152785.diff

2 Files Affected:

  • (modified) llvm/lib/Target/X86/AsmParser/CMakeLists.txt (+1)
  • (modified) openmp/libompd/gdb-plugin/ompdModule.c (+4-3)
diff --git a/llvm/lib/Target/X86/AsmParser/CMakeLists.txt b/llvm/lib/Target/X86/AsmParser/CMakeLists.txt
index ad7e14ccaaecf..01a6634f31456 100644
--- a/llvm/lib/Target/X86/AsmParser/CMakeLists.txt
+++ b/llvm/lib/Target/X86/AsmParser/CMakeLists.txt
@@ -1,6 +1,7 @@
 add_llvm_component_library(LLVMX86AsmParser
   X86AsmParser.cpp
 
+  SHARED
   LINK_COMPONENTS
   MC
   MCParser
diff --git a/openmp/libompd/gdb-plugin/ompdModule.c b/openmp/libompd/gdb-plugin/ompdModule.c
index df602c54aba37..730e6c2b61d63 100644
--- a/openmp/libompd/gdb-plugin/ompdModule.c
+++ b/openmp/libompd/gdb-plugin/ompdModule.c
@@ -1180,9 +1180,10 @@ static PyObject *call_ompd_get_icv_from_scope(PyObject *self, PyObject *args) {
 
   if (retVal != ompd_rc_ok) {
     if (retVal != ompd_rc_incomplete) {
-      _printf("An error occurred when calling ompd_get_icv_from_scope(%i, %i): "
-              "Error code: %d",
-              scope, icvId, retVal);
+      _printf(
+          "An error occurred when calling ompd_get_icv_from_scope(%i, %" PRIu64
+          "): Error code: %d",
+          scope, icvId, retVal);
     }
     return Py_None;
   }

@jhuber6 jhuber6 merged commit 49e28d7 into llvm:main Aug 15, 2025
9 checks passed
searlmc1 pushed a commit to ROCm/llvm-project that referenced this pull request Sep 22, 2025
Update printf format string to match argument list

---------

Co-authored-by: Joachim <[email protected]>
Co-authored-by: Joachim Jenke <[email protected]>
searlmc1 pushed a commit to ROCm/llvm-project that referenced this pull request Oct 9, 2025
Update printf format string to match argument list

---------

Co-authored-by: Joachim <[email protected]>
Co-authored-by: Joachim Jenke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend:X86 openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants