[OpenMP] Update ompdModule.c printf to match argument type #152785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update printf format string to match argument list
llvmbot
added
openmp:libomp
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
jprotze
reviewed
Aug 8, 2025
jhuber6
changed the title
Co-authored-by: Joachim <[email protected]>
jprotze
reviewed
Aug 8, 2025
jprotze
reviewed
Aug 8, 2025
jprotze
approved these changes
Aug 8, 2025
Collaborator
jprotze
left a comment
jprotze
left a comment
There was a problem hiding this comment.
Lgtm, I don't see what clang-format is complaining about
Member
|
@llvm/pr-subscribers-backend-x86 Author: None (CatherineMoore) ChangesUpdate printf format string to match argument list Full diff: https://github.com/llvm/llvm-project/pull/152785.diff 2 Files Affected:
diff --git a/llvm/lib/Target/X86/AsmParser/CMakeLists.txt b/llvm/lib/Target/X86/AsmParser/CMakeLists.txt
index ad7e14ccaaecf..01a6634f31456 100644
--- a/llvm/lib/Target/X86/AsmParser/CMakeLists.txt
+++ b/llvm/lib/Target/X86/AsmParser/CMakeLists.txt
@@ -1,6 +1,7 @@
add_llvm_component_library(LLVMX86AsmParser
X86AsmParser.cpp
+ SHARED
LINK_COMPONENTS
MC
MCParser
diff --git a/openmp/libompd/gdb-plugin/ompdModule.c b/openmp/libompd/gdb-plugin/ompdModule.c
index df602c54aba37..730e6c2b61d63 100644
--- a/openmp/libompd/gdb-plugin/ompdModule.c
+++ b/openmp/libompd/gdb-plugin/ompdModule.c
@@ -1180,9 +1180,10 @@ static PyObject *call_ompd_get_icv_from_scope(PyObject *self, PyObject *args) {
if (retVal != ompd_rc_ok) {
if (retVal != ompd_rc_incomplete) {
- _printf("An error occurred when calling ompd_get_icv_from_scope(%i, %i): "
- "Error code: %d",
- scope, icvId, retVal);
+ _printf(
+ "An error occurred when calling ompd_get_icv_from_scope(%i, %" PRIu64
+ "): Error code: %d",
+ scope, icvId, retVal);
}
return Py_None;
}
|
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Sep 22, 2025
Update printf format string to match argument list --------- Co-authored-by: Joachim <[email protected]> Co-authored-by: Joachim Jenke <[email protected]>
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Oct 9, 2025
Update printf format string to match argument list --------- Co-authored-by: Joachim <[email protected]> Co-authored-by: Joachim Jenke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update printf format string to match argument list