Skip to content

[OpenMP] Update printf stmt in kmp_settings.cpp #152800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

[OpenMP] Update printf stmt in kmp_settings.cpp #152800

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df22471
[OpenMP] Update printf stmt in kmp_settings.cpp
CatherineMoore Aug 8, 2025
1a7beac
Update openmp/runtime/src/kmp_settings.cpp
CatherineMoore Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openmp/runtime/src/kmp_settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3278,9 +3278,9 @@ static void __kmp_stg_print_places(kmp_str_buf_t *buffer, char const *name,
int eff = __kmp_affinity.core_attr_gran.core_eff;
if (ct != KMP_HW_CORE_TYPE_UNKNOWN) {
const char *ct_name = __kmp_hw_get_core_type_keyword(ct);
__kmp_str_buf_print(buffer, ":%s", name, ct_name);
__kmp_str_buf_print(buffer, ":%s", ct_name);
} else if (eff >= 0 && eff < KMP_HW_MAX_NUM_CORE_EFFS) {
__kmp_str_buf_print(buffer, ":eff%d", name, eff);
__kmp_str_buf_print(buffer, ":eff%d", eff);
Copy link
Contributor

@jhuber6 jhuber6 Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little confusing to me, the usage above is the same where we have one printf argument and then the actual thing being printed. Is __kmp_str_buf_print different and takes the extra argument implicitly?

}
}

Expand Down
Loading