Skip to content

[mlir][affine] Fix crash in affine-loop-fusion by validating access relation IDs #152812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[mlir][affine] Fix crash in affine-loop-fusion by validating access relation IDs #152812

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6e92e9
fix: return failure in getAccessRelation if rel ids are not in domain
Baxi-codes Aug 8, 2025
26b9d9b
Replace std::find with llvm::is_contained to check membership
Baxi-codes Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "mlir/Dialect/Affine/IR/AffineValueMap.h"
#include "mlir/Interfaces/SideEffectInterfaces.h"
#include "mlir/Interfaces/ViewLikeInterface.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/TypeSwitch.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/raw_ostream.h"
Expand Down Expand Up @@ -468,7 +469,18 @@ LogicalResult MemRefAccess::getAccessRelation(IntegerRelation &rel) const {

// Merge and align domain ids of `rel` with ids of `domain`. Since the domain
// of the access map is a subset of the domain of access, the domain ids of
// `rel` are guranteed to be a subset of ids of `domain`.
// `rel` should be a subset of ids of `domain`. If not, return failure.

for (unsigned i = 0, e = rel.getNumDimVars(); i < e; ++i) {
if (rel.getVarKindAt(i) != VarKind::SetDim)
continue;
Identifier idi = rel.getIds(VarKind::SetDim)[i];
ArrayRef<Identifier> domainIds = domain.getIds(VarKind::SetDim);
if (llvm::is_contained(domainIds, idi)) {
return failure();
}
}

unsigned inserts = 0;
for (unsigned i = 0, e = domain.getNumDimVars(); i < e; ++i) {
const Identifier domainIdi = Identifier(domain.getValue(i));
Expand Down