[Clang][NFC] - Use Hex Encoding for Intel CPU CPUID family #153004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@e-kud @phoebewang Ping for review. |
e-kud
approved these changes
Aug 11, 2025
| } | ||
| break; | ||
| case 15: { | ||
| case 0xf: { |
Contributor
There was a problem hiding this comment.
I'm not sure whether it is better to use 0x0f since now we have two hex digits for families.
phoebewang
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Hex Encoding for CPUID family to match number format with Intel ISE rev.58:
https://cdrdv2.intel.com/v1/dl/getContent/671368